From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF0AEC43218 for ; Sun, 28 Apr 2019 17:44:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B80720675 for ; Sun, 28 Apr 2019 17:44:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727012AbfD1RoF (ORCPT ); Sun, 28 Apr 2019 13:44:05 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:59118 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726299AbfD1RoF (ORCPT ); Sun, 28 Apr 2019 13:44:05 -0400 Received: from callcc.thunk.org (75-104-85-194.mobility.exede.net [75.104.85.194] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x3SHhG5b013749 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 28 Apr 2019 13:43:25 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 278EF420023; Sun, 28 Apr 2019 13:43:15 -0400 (EDT) Date: Sun, 28 Apr 2019 13:43:15 -0400 From: "Theodore Ts'o" To: Masahiro Yamada Cc: Olaf Weber , Gabriel Krisman Bertazi , Gabriel Krisman Bertazi , "open list:DOCUMENTATION" , Linux Kbuild mailing list , Linux Kernel Mailing List , Jonathan Corbet , Michal Marek , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] unicode: refactor the rule for regenerating utf8data.h Message-ID: <20190428174315.GC24089@mit.edu> Mail-Followup-To: Theodore Ts'o , Masahiro Yamada , Olaf Weber , Gabriel Krisman Bertazi , Gabriel Krisman Bertazi , "open list:DOCUMENTATION" , Linux Kbuild mailing list , Linux Kernel Mailing List , Jonathan Corbet , Michal Marek , linux-fsdevel@vger.kernel.org References: <1556346241-10451-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Thanks, for the suggestion and the patch! I agree it's much better with your proposed change (and it gets mkutf8data out of your hair :-) I did need to make one change to your patch in order for it to work correctly with a build directory. That is, to support make -O /build/ext4 REGENERATE_UTF8DATA=1 fs/unicode/ I'll apply it to the ext4 git tree with this change. - Ted diff --git a/fs/unicode/Makefile b/fs/unicode/Makefile index 1a109b7a1da9..45955264ac04 100644 --- a/fs/unicode/Makefile +++ b/fs/unicode/Makefile @@ -14,13 +14,13 @@ $(obj)/utf8-norm.o: $(obj)/utf8data.h quiet_cmd_utf8data = GEN $@ cmd_utf8data = $(obj)/mkutf8data \ - -a $(src)/DerivedAge.txt \ - -c $(src)/DerivedCombiningClass.txt \ - -p $(src)/DerivedCoreProperties.txt \ - -d $(src)/UnicodeData.txt \ - -f $(src)/CaseFolding.txt \ - -n $(src)/NormalizationCorrections.txt \ - -t $(src)/NormalizationTest.txt \ + -a $(srctree)/$(src)/DerivedAge.txt \ + -c $(srctree)/$(src)/DerivedCombiningClass.txt \ + -p $(srctree)/$(src)/DerivedCoreProperties.txt \ + -d $(srctree)/$(src)/UnicodeData.txt \ + -f $(srctree)/$(src)/CaseFolding.txt \ + -n $(srctree)/$(src)/NormalizationCorrections.txt \ + -t $(srctree)/$(src)/NormalizationTest.txt \ -o $@ $(obj)/utf8data.h: $(filter %.txt, $(cmd_utf8data)) $(obj)/mkutf8data FORCE