From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70800C04AAF for ; Thu, 16 May 2019 11:55:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D3AD20645 for ; Thu, 16 May 2019 11:55:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727275AbfEPLzi (ORCPT ); Thu, 16 May 2019 07:55:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:40812 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727242AbfEPLzi (ORCPT ); Thu, 16 May 2019 07:55:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 22EC8ACAA; Thu, 16 May 2019 11:55:37 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 3B561DA86C; Thu, 16 May 2019 13:56:36 +0200 (CEST) Date: Thu, 16 May 2019 13:56:36 +0200 From: David Sterba To: Amir Goldstein Cc: Jan Kara , Matthew Bobrowski , linux-fsdevel@vger.kernel.org, Chris Mason , Josef Bacik , David Sterba Subject: Re: [PATCH v2 10/14] fsnotify: call fsnotify_rmdir() hook from btrfs Message-ID: <20190516115635.GY3138@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20190516102641.6574-1-amir73il@gmail.com> <20190516102641.6574-11-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190516102641.6574-11-amir73il@gmail.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, May 16, 2019 at 01:26:37PM +0300, Amir Goldstein wrote: > This will allow generating fsnotify delete events after the > fsnotify_nameremove() hook is removed from d_delete(). > > Cc: Chris Mason > Cc: Josef Bacik > Cc: David Sterba > Signed-off-by: Amir Goldstein > --- > fs/btrfs/ioctl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c > index 6dafa857bbb9..2cfd1bfb3871 100644 > --- a/fs/btrfs/ioctl.c > +++ b/fs/btrfs/ioctl.c > @@ -2930,8 +2930,10 @@ static noinline int btrfs_ioctl_snap_destroy(struct file *file, > inode_lock(inode); > err = btrfs_delete_subvolume(dir, dentry); > inode_unlock(inode); > - if (!err) > + if (!err) { > + fsnotify_rmdir(dir, dentry); > d_delete(dentry); Ok, this is the only instance of d_delete. Acked-by: David Sterba