From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B520CC04AAF for ; Sat, 18 May 2019 20:19:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9434E2087B for ; Sat, 18 May 2019 20:19:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729106AbfERUTF (ORCPT ); Sat, 18 May 2019 16:19:05 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:59481 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727620AbfERUTF (ORCPT ); Sat, 18 May 2019 16:19:05 -0400 Received: from callcc.thunk.org ([66.31.38.53]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x4IKIvcp010106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 May 2019 16:18:58 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id AF74E420027; Sat, 18 May 2019 16:18:43 -0400 (EDT) Date: Sat, 18 May 2019 16:18:43 -0400 From: "Theodore Ts'o" To: Al Viro Cc: Dmitry Vyukov , syzbot , linux-fsdevel , LKML , sabin.rapan@gmail.com, syzkaller-bugs Subject: Re: BUG: unable to handle kernel paging request in do_mount Message-ID: <20190518201843.GD14277@mit.edu> Mail-Followup-To: Theodore Ts'o , Al Viro , Dmitry Vyukov , syzbot , linux-fsdevel , LKML , sabin.rapan@gmail.com, syzkaller-bugs References: <00000000000014285d05765bf72a@google.com> <0000000000000eaf23058912af14@google.com> <20190517134850.GG17978@ZenIV.linux.org.uk> <20190518162142.GH17978@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190518162142.GH17978@ZenIV.linux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, May 18, 2019 at 05:21:42PM +0100, Al Viro wrote: > IOW, Dan's fix folded into the offending commit. And that kind of > pattern is not rare; I would argue that appending Dan's patch at > the end of queue and leaving the crap in between would be a fucking > bad idea - it would've left a massive bisection hazard *and* made > life much more unpleasant when the things got to merging into the > mainline (or reviewing, for that matter). When this happens in the ext4 git tree, I usually don't worry about giving credit to whatever system finds the problem, whether coming from it's Coverity, or someone running sparse, or syzbot, etc. There will always be issues where there are no way to clear out the syzbot report via a commit description --- for example, when a patch gets dropped entirely from linux-next. With Coverity, the report gets dropped automatically. With syzbot, it will have closed out by hand. > What would you prefer to happen in such situations? Commit summaries > modified enough to confuse CI tools into *NOT* noticing that those > are versions of the same patch? Some kind of metadata telling the > same tools that such-and-such commits got folded in (and they might > have been split in process, with parts folded into different spots > in the series, at that)? > > Because "never fold in, never reorder, just accumulate patches in > the end of the series" is not going to fly. For a lot of reasons. As far as I'm concerned, this is the tools problem; I don't think it's worth it for developers to feel they need to twist themselves into knots just to try to make the CI tools' life easier. - Ted