From: Luis Henriques <lhenriques@suse.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: "Darrick J . Wong" <darrick.wong@oracle.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
Olga Kornievskaia <olga.kornievskaia@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
ceph-devel@vger.kernel.org, linux-api@vger.kernel.org,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH v2 6/8] vfs: copy_file_range should update file timestamps
Date: Mon, 27 May 2019 15:35:39 +0100 [thread overview]
Message-ID: <20190527143539.GA14980@hermes.olymp> (raw)
In-Reply-To: <20190526061100.21761-7-amir73il@gmail.com>
On Sun, May 26, 2019 at 09:10:57AM +0300, Amir Goldstein wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Timestamps are not updated right now, so programs looking for
> timestamp updates for file modifications (like rsync) will not
> detect that files have changed. We are also accessing the source
> data when doing a copy (but not when cloning) so we need to update
> atime on the source file as well.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
> fs/read_write.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/fs/read_write.c b/fs/read_write.c
> index e16bcafc0da2..4b23a86aacd9 100644
> --- a/fs/read_write.c
> +++ b/fs/read_write.c
> @@ -1576,6 +1576,16 @@ int generic_copy_file_range_prep(struct file *file_in, struct file *file_out)
>
> WARN_ON_ONCE(!inode_is_locked(file_inode(file_out)));
>
> + /* Update source timestamps, because we are accessing file data */
> + file_accessed(file_in);
> +
> + /* Update destination timestamps, since we can alter file contents. */
> + if (!(file_out->f_mode & FMODE_NOCMTIME)) {
> + ret = file_update_time(file_out);
> + if (ret)
> + return ret;
> + }
> +
Is this the right place for updating the timestamps? I see that in same
cases we may be updating the timestamp even if there was an error and no
copy was performed. For example, if file_remove_privs fails.
(btw, I've re-tested everything on ceph and everything seems to be
working fine.)
Cheers,
--
Luís
> /*
> * Clear the security bits if the process is not being run by root.
> * This keeps people from modifying setuid and setgid binaries.
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2019-05-27 14:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 6:10 [PATCH v2 0/8] Fixes for major copy_file_range() issues Amir Goldstein
2019-05-26 6:10 ` [PATCH v2 1/8] vfs: introduce generic_copy_file_range() Amir Goldstein
2019-05-28 16:11 ` Darrick J. Wong
2019-05-26 6:10 ` [PATCH v2 2/8] vfs: no fallback for ->copy_file_range Amir Goldstein
2019-05-28 16:09 ` Darrick J. Wong
2019-05-26 6:10 ` [PATCH v2 3/8] vfs: introduce generic_file_rw_checks() Amir Goldstein
2019-05-28 16:14 ` Darrick J. Wong
2019-05-26 6:10 ` [PATCH v2 4/8] vfs: add missing checks to copy_file_range Amir Goldstein
2019-05-28 16:18 ` Darrick J. Wong
2019-05-28 16:26 ` Amir Goldstein
2019-05-28 16:31 ` Darrick J. Wong
2019-05-28 16:39 ` Amir Goldstein
2019-05-26 6:10 ` [PATCH v2 5/8] vfs: copy_file_range needs to strip setuid bits Amir Goldstein
2019-05-28 16:25 ` Darrick J. Wong
2019-05-31 19:34 ` J. Bruce Fields
2019-05-26 6:10 ` [PATCH v2 6/8] vfs: copy_file_range should update file timestamps Amir Goldstein
2019-05-27 14:35 ` Luis Henriques [this message]
2019-05-27 22:05 ` Dave Chinner
2019-05-28 8:53 ` Luis Henriques
2019-05-28 16:30 ` Darrick J. Wong
2019-05-28 16:36 ` Amir Goldstein
2019-05-26 6:10 ` [PATCH v2 7/8] vfs: allow copy_file_range to copy across devices Amir Goldstein
2019-05-28 16:34 ` Darrick J. Wong
2019-05-26 6:10 ` [PATCH v2 8/8] vfs: remove redundant checks from generic_remap_checks() Amir Goldstein
2019-05-28 16:37 ` Darrick J. Wong
2019-05-26 6:11 ` [PATCH v2 9/8] man-pages: copy_file_range updates Amir Goldstein
2019-05-28 16:48 ` Darrick J. Wong
2019-05-29 16:20 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527143539.GA14980@hermes.olymp \
--to=lhenriques@suse.com \
--cc=amir73il@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=olga.kornievskaia@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).