From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DEC8C04AB6 for ; Tue, 28 May 2019 16:08:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFA69208C3 for ; Tue, 28 May 2019 16:08:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726708AbfE1QIU (ORCPT ); Tue, 28 May 2019 12:08:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:56526 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726243AbfE1QIU (ORCPT ); Tue, 28 May 2019 12:08:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0A8B0AF3B; Tue, 28 May 2019 16:08:19 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id A62951E3F53; Tue, 28 May 2019 18:08:18 +0200 (CEST) Date: Tue, 28 May 2019 18:08:18 +0200 From: Jan Kara To: Amir Goldstein Cc: Jan Kara , linux-fsdevel Subject: Re: [PATCH v2] fanotify: Disallow permission events for proc filesystem Message-ID: <20190528160818.GB27155@quack2.suse.cz> References: <20190516115619.18926-1-jack@suse.cz> <20190528155430.GA27155@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue 28-05-19 19:02:46, Amir Goldstein wrote: > On Tue, May 28, 2019 at 6:54 PM Jan Kara wrote: > > > > On Thu 16-05-19 13:56:19, Jan Kara wrote: > > > Proc filesystem has special locking rules for various files. Thus > > > fanotify which opens files on event delivery can easily deadlock > > > against another process that waits for fanotify permission event to be > > > handled. Since permission events on /proc have doubtful value anyway, > > > just disallow them. > > > > > > Link: https://lore.kernel.org/linux-fsdevel/20190320131642.GE9485@quack2.suse.cz/ > > > Signed-off-by: Jan Kara > > > > Amir, ping? What do you think about this version of the patch? > > Sorry, I reviewed but forgot to reply. > You may add: > Reviewed-by: Amir Goldstein Thanks! I'll push it to my tree for the next merge window then. Honza -- Jan Kara SUSE Labs, CR