From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CFC3C28CC0 for ; Thu, 30 May 2019 12:27:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CCA825170 for ; Thu, 30 May 2019 12:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559219247; bh=Zu7egCdvljXGfB3X0g+OTpnio/1b3nMmqQhAksx//C8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=k2kHSHalCYr4SzKVXUlaqF7fGurj5h3mGThoQPixqYtq1auv5DOxC7k5SsUwBREYU RzGFr6sQ+31fetKwz0opFmqPMaARbDe025DYrFrttIAQDgAdlQGDvm0I9wf42TMhnq hyzgBYNDXDonR8hwxzVFZc2kmb7fVQ+CcMRmhD18= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727216AbfE3M10 (ORCPT ); Thu, 30 May 2019 08:27:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:34736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727185AbfE3M10 (ORCPT ); Thu, 30 May 2019 08:27:26 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1693248B4; Thu, 30 May 2019 12:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559219245; bh=Zu7egCdvljXGfB3X0g+OTpnio/1b3nMmqQhAksx//C8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OAxxz+p9rIs3KejKTK3Xx9a83hMQfV1WIAwhfVxPIfN5IiCGs1XNp/TREDK7DcyJ7 62tp6cGMIhBr/OE0WaC619zni6LuxLnBjWEIsAFElcbjyUiRq6fg3XQ1D+6P7NEm7N fLxBtBe91NhXw1jrcYWqfm48gSp0k5kI067tnf6Y= Date: Thu, 30 May 2019 05:27:25 -0700 From: Greg KH To: Amir Goldstein Cc: David Sterba , Christoph Hellwig , Joel Becker , John Johansen , Trond Myklebust , Anna Schumaker , Steven Rostedt , Al Viro , linux-fsdevel , Jan Kara Subject: Re: [PATCH v3 06/10] debugfs: simplify __debugfs_remove_file() Message-ID: <20190530122725.GA17734@kroah.com> References: <20190526143411.11244-1-amir73il@gmail.com> <20190526143411.11244-7-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, May 30, 2019 at 08:49:52AM +0300, Amir Goldstein wrote: > On Sun, May 26, 2019 at 5:34 PM Amir Goldstein wrote: > > > > Move simple_unlink()+d_delete() from __debugfs_remove_file() into > > caller __debugfs_remove() and rename helper for post remove file to > > __debugfs_file_removed(). > > > > This will simplify adding fsnotify_unlink() hook. > > > > Cc: Greg Kroah-Hartman > > Hi Greg, > > Will be you be able to provide an ACK on this debugfs patch and the next one. It's only been 4 days, and I'm traveling this week, give me a chance...