From: Eric Wong <e@80x24.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
arnd@arndb.de, dbueso@suse.de, axboe@kernel.dk,
dave@stgolabs.net, jbaron@akamai.com,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
omar.kilani@gmail.com, tglx@linutronix.de,
stable@vger.kernel.org
Subject: Re: pselect/etc semantics
Date: Thu, 30 May 2019 21:03:18 +0000 [thread overview]
Message-ID: <20190530210318.dbappo23kdcysraw@dcvr> (raw)
In-Reply-To: <87woi8rt96.fsf@xmission.com>
"Eric W. Biederman" <ebiederm@xmission.com> wrote:
> Frankly the only reason this appears to be worth touching is that we
> have a userspace regression. Otherwise I would call the current
> behavior more correct and desirable than ignoring the signal longer.
>
> If I am reading sitaution properly I suggest we go back to resoring the
> sigmask by hand in epoll_pwait, and put in a big fat comment about a
> silly userspace program depending on that behavior.
>
> That will be easier to backport and it will just fix the regression and
> not overfix the problem for reasonable applications.
Fwiw, the cmogstored (userspace program which regressed) only
hit this regression in an obscure code path for tuning; that
code path probably sees no use outside of the test suite.
Add to that, cmogstored is an unofficial and optional component
to the obscure, largely-forgotten MogileFS.
Finally, the main users of cmogstored are on FreeBSD. They
hit the kqueue+self-pipe code path instead of epoll_pwait.
I only used epoll_pwait on Linux since I figured I could save a
few bytes of memory by skipping eventfd/self-pipe...
Anyways, I updated cmogstored a few weeks back to call `note_run'
(the signal dispatcher) if epoll_pwait (wrapped by `mog_idleq_wait_intr')
returns 0 instead of -1 (EINTR) to workaround this kernel change:
https://bogomips.org/cmogstored-public/20190511075630.17811-1-e@80x24.org/
I could easily make a change to call `note_run' unconditionally
when `mog_idleq_wait_intr' returns, too.
But that said, there could be other users hitting the same
problem I did. So maybe cmogstored's primary use on Linux these
days is finding regressions :>
next prev parent reply other threads:[~2019-05-30 21:03 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 3:21 [PATCH v2] signal: Adjust error codes according to restore_user_sigmask() Deepa Dinamani
2019-05-22 15:05 ` Oleg Nesterov
2019-05-22 15:55 ` Deepa Dinamani
2019-05-22 16:14 ` Oleg Nesterov
2019-05-22 16:33 ` Deepa Dinamani
2019-05-23 9:03 ` David Laight
2019-05-23 14:59 ` Oleg Nesterov
2019-05-23 16:18 ` David Laight
2019-05-23 16:36 ` Oleg Nesterov
2019-05-23 16:56 ` David Laight
2019-05-23 18:06 ` Deepa Dinamani
2019-05-23 20:41 ` Deepa Dinamani
2019-05-23 21:06 ` Deepa Dinamani
2019-05-24 9:58 ` David Laight
2019-05-24 14:10 ` Oleg Nesterov
2019-05-24 15:16 ` Deepa Dinamani
2019-05-24 16:33 ` Oleg Nesterov
2019-05-24 17:01 ` Deepa Dinamani
2019-05-27 15:04 ` Oleg Nesterov
2019-05-28 20:47 ` Deepa Dinamani
2019-05-29 16:57 ` Oleg Nesterov
2019-05-29 18:42 ` Deepa Dinamani
2019-05-28 9:02 ` David Laight
2019-05-28 9:12 ` David Laight
2019-05-28 11:37 ` Deepa Dinamani
2019-05-28 12:04 ` David Laight
2019-05-24 14:19 ` Oleg Nesterov
2019-05-24 14:29 ` Deepa Dinamani
2019-05-24 14:51 ` Oleg Nesterov
2019-05-24 13:29 ` Oleg Nesterov
2019-05-24 14:59 ` David Laight
2019-05-24 15:09 ` David Laight
2019-05-24 15:46 ` Oleg Nesterov
2019-05-24 15:44 ` Oleg Nesterov
2019-05-24 16:40 ` David Laight
2019-05-23 14:33 ` Oleg Nesterov
2019-05-22 22:18 ` Chris Down
2019-05-22 22:52 ` Deepa Dinamani
2019-05-29 16:11 ` pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()) Oleg Nesterov
2019-05-29 16:54 ` David Laight
2019-05-29 18:50 ` Eric Wong
2019-05-30 9:34 ` David Laight
2019-05-30 13:04 ` pselect/etc semantics Eric W. Biederman
2019-05-29 16:56 ` pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()) Deepa Dinamani
2019-05-29 18:26 ` Deepa Dinamani
2019-05-29 22:32 ` Arnd Bergmann
2019-05-30 1:54 ` pselect/etc semantics Eric W. Biederman
2019-05-30 18:28 ` Arnd Bergmann
2019-05-30 14:40 ` pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()) Oleg Nesterov
2019-05-30 18:37 ` Arnd Bergmann
2019-05-30 13:01 ` pselect/etc semantics Eric W. Biederman
2019-05-30 15:18 ` David Laight
2019-05-30 16:13 ` Oleg Nesterov
2019-05-30 15:38 ` Eric W. Biederman
2019-05-30 15:48 ` Deepa Dinamani
2019-05-30 16:59 ` Deepa Dinamani
2019-05-30 16:08 ` Oleg Nesterov
2019-05-30 17:20 ` Eric W. Biederman
2019-05-30 16:22 ` David Laight
2019-05-30 15:57 ` Oleg Nesterov
2019-05-30 21:03 ` Eric Wong [this message]
2019-06-04 13:41 ` [PATCH] signal: remove the wrong signal_pending() check in restore_user_sigmask() Oleg Nesterov
2019-06-04 15:31 ` Eric W. Biederman
2019-06-04 15:57 ` David Laight
2019-06-04 16:37 ` Arnd Bergmann
2019-06-04 18:14 ` Deepa Dinamani
2019-06-04 18:35 ` Eric Wong
2019-06-04 21:26 ` Linus Torvalds
2019-06-04 22:24 ` Eric Wong
2019-06-04 23:51 ` Eric W. Biederman
2019-06-05 9:04 ` Oleg Nesterov
2019-06-05 8:56 ` Oleg Nesterov
2019-06-05 9:02 ` David Laight
2019-06-05 9:25 ` Oleg Nesterov
2019-06-05 9:58 ` David Laight
2019-06-05 15:58 ` [PATCH -mm 0/1] signal: simplify set_user_sigmask/restore_user_sigmask Oleg Nesterov
2019-06-05 15:58 ` [PATCH -mm 1/1] " Oleg Nesterov
2019-06-06 0:14 ` kbuild test robot
2019-06-06 1:06 ` kbuild test robot
2019-06-06 7:25 ` Oleg Nesterov
2019-06-06 7:30 ` Sedat Dilek
2019-06-05 17:24 ` [PATCH -mm 0/1] " Linus Torvalds
2019-06-06 9:05 ` David Laight
2019-06-06 11:05 ` Oleg Nesterov
2019-06-06 11:29 ` David Laight
2019-06-06 12:41 ` Oleg Nesterov
2019-06-06 13:23 ` David Laight
2019-06-06 10:22 ` Oleg Nesterov
2019-06-06 11:32 ` [PATCH -mm V2 1/1] " Oleg Nesterov
2019-06-06 14:08 ` [PATCH 0/2] select: simplify the usage of restore_saved_sigmask_unless() Oleg Nesterov
2019-06-06 14:08 ` [PATCH 1/2] select: change do_poll() to return -ERESTARTNOHAND rather than -EINTR Oleg Nesterov
2019-06-07 18:05 ` Linus Torvalds
2019-06-06 14:09 ` [PATCH 2/2] select: shift restore_saved_sigmask_unless() into poll_select_copy_remaining() Oleg Nesterov
2019-06-07 21:39 ` [RFC PATCH 0/5]: Removing saved_sigmask Eric W. Biederman
2019-06-07 21:41 ` [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask Eric W. Biederman
2019-06-07 22:07 ` Linus Torvalds
2019-06-10 16:22 ` Oleg Nesterov
2019-06-10 21:20 ` Eric W. Biederman
2019-06-11 9:52 ` David Laight
2019-06-11 11:14 ` David Laight
2019-06-12 12:55 ` Eric W. Biederman
2019-06-12 13:24 ` David Laight
2019-06-12 13:35 ` Oleg Nesterov
2019-06-12 13:39 ` David Laight
2019-06-11 15:46 ` David Laight
2019-06-12 12:40 ` Eric W. Biederman
2019-06-12 13:45 ` Oleg Nesterov
2019-06-12 14:18 ` David Laight
2019-06-12 15:11 ` Eric W. Biederman
2019-06-12 15:37 ` Oleg Nesterov
2019-06-13 8:48 ` David Laight
2019-06-13 9:43 ` Oleg Nesterov
2019-06-13 10:56 ` David Laight
2019-06-13 12:43 ` Oleg Nesterov
2019-06-11 18:55 ` Oleg Nesterov
2019-06-11 19:02 ` Eric W. Biederman
2019-06-12 8:39 ` David Laight
2019-06-12 13:09 ` Eric W. Biederman
2019-06-07 21:41 ` [RFC PATCH 2/5] signal/kvm: Stop using sigprocmask in kvm_sigset_(activate|deactivate) Eric W. Biederman
2019-06-07 21:42 ` [RFC PATCH 3/5] signal: Always keep real_blocked in sync with blocked Eric W. Biederman
2019-06-07 21:43 ` [RFC PATCH 4/5] signal: Remove saved_sigmask Eric W. Biederman
2019-06-07 21:44 ` [RFC PATCH 5/5] signal: Remove the unnecessary restore_sigmask flag Eric W. Biederman
2019-06-11 18:58 ` [RFC PATCH 0/5]: Removing saved_sigmask Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530210318.dbappo23kdcysraw@dcvr \
--to=e@80x24.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=deepa.kernel@gmail.com \
--cc=ebiederm@xmission.com \
--cc=jbaron@akamai.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=omar.kilani@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).