Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Enrico Weigelt, metux IT consult" <lkml@metux.net>,
	util-linux@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: Help with reviewing dosfstools patches
Date: Fri, 14 Jun 2019 21:08:03 +0200
Message-ID: <20190614190803.2wg3gky5gypge6xp@pali> (raw)
In-Reply-To: <20190614143052.GA21822@infradead.org>

[-- Attachment #1: Type: text/plain, Size: 1733 bytes --]

On Friday 14 June 2019 07:30:52 Christoph Hellwig wrote:
> On Fri, Jun 14, 2019 at 04:25:34PM +0200, Pali Rohár wrote:
> > > Does the project already have a maillist ?
> > 
> > No, there is no mailing list. Basically whole development is on github
> > via github pull requests where are also put review comments and where is
> > also whole discussion, including bug reports.
> 
> That could explain why it is lacking qualified reviewers..

That is not my decision. Probably current maintainer of dosfstools like
it. But nowadays do not have much more time and gave me commit access.

Main benefit of github pull requests is that every one pull request
patch is automatically compiled and tested on i686, x86_64, x32, arm
and big endian powerpc systems via Travis CI. So author and also
reviewers/people with commit access immediately know if proposed change
could break something.

I like automated testing on more platforms, because lot of people either
do not know or do not have access to different systems just for testing.
And this can show possible problems...

Setting up a new mailing list, configuring some testing server, copying
existing patches from github to list, etc... is just tons of work for
which I basically do not have a time. Therefore I asked for help to
review existing stuff with minimal technical time setup.

I understand that it is not ideal for everybody, but for current
contributors it is probably better. I have already reviewed and merged
more patches, just those which are mine are left open, so more eyes can
look at them.

If you or somebody else have time and want to improve dosfstools
project, I'm not against it...

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 10:25 Pali Rohár
2019-06-14 14:20 ` Enrico Weigelt, metux IT consult
2019-06-14 14:25   ` Pali Rohár
2019-06-14 14:30     ` Christoph Hellwig
2019-06-14 19:08       ` Pali Rohár [this message]
2019-06-14 15:45   ` Enrico Weigelt, metux IT consult
2019-06-14 18:45     ` Enrico Weigelt, metux IT consult
2019-06-14 19:10     ` Pali Rohár

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190614190803.2wg3gky5gypge6xp@pali \
    --to=pali.rohar@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@metux.net \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org linux-fsdevel@archiver.kernel.org
	public-inbox-index linux-fsdevel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox