From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37F2BC48BE3 for ; Fri, 21 Jun 2019 22:00:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02916208CA for ; Fri, 21 Jun 2019 22:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561154412; bh=hUnaoo5Fb3iD0gMCezjWig2sF2hiXRU9hbzHDO5W2lA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=eIXdW4Jg6L55lNreS9fgXx7NyPh3ptbn8mYewL/rv+YBKBg1nhsaOeIGOFqWq4ANP EN7PP3ZTXrhPcmHAkEuAESfYSOVSu9tqefY+8Y08RilChvv0WuJfC8qNpPtObobfsa cchl30yBDfuTM/PKJINphd0GCONHRG8YyW/gkvhg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726259AbfFUWAL (ORCPT ); Fri, 21 Jun 2019 18:00:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:36280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbfFUWAK (ORCPT ); Fri, 21 Jun 2019 18:00:10 -0400 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05E6120679; Fri, 21 Jun 2019 22:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561154410; bh=hUnaoo5Fb3iD0gMCezjWig2sF2hiXRU9hbzHDO5W2lA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tSfkN83sBckuomdVEtOy4k3noQiM89Lmivj0BzVuvFLSEdTbiw7IaDsGirwrQerw/ MW4Dqx+UYmefgeEdCRAP32VCR2cAaFOlIb2y53zDI6KZ6fMGMqL3UjvZ0vDOk6EUWj 9gQs/C4xiuuXjWZ+2QiLjWqlFcg60PmwhQ8pcMYw= Date: Fri, 21 Jun 2019 15:00:08 -0700 From: Eric Biggers To: Chandan Rajendra Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, yuchao0@huawei.com, hch@infradead.org Subject: Re: [PATCH V3 3/7] fscrypt: remove struct fscrypt_ctx Message-ID: <20190621220007.GE167064@gmail.com> References: <20190616160813.24464-1-chandan@linux.ibm.com> <20190616160813.24464-4-chandan@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190616160813.24464-4-chandan@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, Jun 16, 2019 at 09:38:09PM +0530, Chandan Rajendra wrote: > -/** > - * fscrypt_get_ctx() - Get a decryption context > - * @gfp_flags: The gfp flag for memory allocation > - * > - * Allocate and initialize a decryption context. > - * > - * Return: A new decryption context on success; an ERR_PTR() otherwise. > - */ > -struct fscrypt_ctx *fscrypt_get_ctx(gfp_t gfp_flags) > -{ > - struct fscrypt_ctx *ctx; > - unsigned long flags; > - > - /* > - * First try getting a ctx from the free list so that we don't have to > - * call into the slab allocator. > - */ > - spin_lock_irqsave(&fscrypt_ctx_lock, flags); > - ctx = list_first_entry_or_null(&fscrypt_free_ctxs, > - struct fscrypt_ctx, free_list); > - if (ctx) > - list_del(&ctx->free_list); > - spin_unlock_irqrestore(&fscrypt_ctx_lock, flags); > - if (!ctx) { > - ctx = kmem_cache_zalloc(fscrypt_ctx_cachep, gfp_flags); > - if (!ctx) > - return ERR_PTR(-ENOMEM); > - ctx->flags |= FS_CTX_REQUIRES_FREE_ENCRYPT_FL; > - } else { > - ctx->flags &= ~FS_CTX_REQUIRES_FREE_ENCRYPT_FL; > - } > - return ctx; > -} > -EXPORT_SYMBOL(fscrypt_get_ctx); FS_CTX_REQUIRES_FREE_ENCRYPT_FL is no longer used, so should be removed. - Eric