From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0977C43613 for ; Mon, 24 Jun 2019 10:58:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C32FF2146E for ; Mon, 24 Jun 2019 10:58:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729262AbfFXK6C (ORCPT ); Mon, 24 Jun 2019 06:58:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:48188 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727730AbfFXK6C (ORCPT ); Mon, 24 Jun 2019 06:58:02 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 21505ACBA; Mon, 24 Jun 2019 10:58:01 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id A60F91E2F23; Mon, 24 Jun 2019 12:58:00 +0200 (CEST) Date: Mon, 24 Jun 2019 12:58:00 +0200 From: Jan Kara To: Eric Sandeen Cc: fsdevel , Jan Kara , linux-xfs , "linux-ext4@vger.kernel.org" , Bob Peterson Subject: Re: [PATCH] quota: honor quote type in Q_XGETQSTAT[V] calls Message-ID: <20190624105800.GD32376@quack2.suse.cz> References: <0b96d49c-3c0b-eb71-dd87-750a6a48f1ef@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0b96d49c-3c0b-eb71-dd87-750a6a48f1ef@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri 21-06-19 18:27:13, Eric Sandeen wrote: > The code in quota_getstate and quota_getstatev is strange; it > says the returned fs_quota_stat[v] structure has room for only > one type of time limits, so fills it in with the first enabled > quota, even though every quotactl command must have a type sent > in by the user. > > Instead of just picking the first enabled quota, fill in the > reply with the timers for the quota type that was actually > requested. > > Signed-off-by: Eric Sandeen > --- > > I guess this is a change in behavior, but it goes from a rather > unexpected and unpredictable behavior to something more expected, > so I hope it's ok. > > I'm working on breaking out xfs quota timers by type as well > (they are separate on disk, but not in memory) so I'll work > up an xfstest to go with this... Yeah, makes sense. I've added the patch to my tree. Honza -- Jan Kara SUSE Labs, CR