linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] iomap: don't mark the inode dirty in iomap_write_end
Date: Wed, 26 Jun 2019 14:55:02 +0200	[thread overview]
Message-ID: <20190626125502.GB4744@lst.de> (raw)
In-Reply-To: <20190626120333.13310-1-agruenba@redhat.com>

On Wed, Jun 26, 2019 at 02:03:32PM +0200, Andreas Gruenbacher wrote:
> Marking the inode dirty for each page copied into the page cache can be
> very inefficient for file systems that use the VFS dirty inode tracking,
> and is completely pointless for those that don't use the VFS dirty inode
> tracking.  So instead, only set an iomap flag when changing the in-core
> inode size, and open code the rest of __generic_write_end.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

Nitpick: a patch from you should never have me as the first signoff.
Just drop it, and if you feel fancy add a 'Partially based on code
from Christoph Hellwig.' sentence.  Not that I care much.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Doesn't the series also need a third patch reducing the amount
of mark_inode_dirty calls as per your initial proposal?

  parent reply	other threads:[~2019-06-26 12:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26 12:03 [PATCH 1/2] iomap: don't mark the inode dirty in iomap_write_end Andreas Gruenbacher
2019-06-26 12:03 ` [PATCH 2/2] fs: fold __generic_write_end back into generic_write_end Andreas Gruenbacher
2019-06-26 12:55   ` Christoph Hellwig
2019-06-26 12:55 ` Christoph Hellwig [this message]
2019-06-26 13:17   ` [PATCH 1/2] iomap: don't mark the inode dirty in iomap_write_end Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626125502.GB4744@lst.de \
    --to=hch@lst.de \
    --cc=agruenba@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).