From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89F68C48BD3 for ; Wed, 26 Jun 2019 20:10:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B06E2086D for ; Wed, 26 Jun 2019 20:10:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="2ZHWFR7p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726422AbfFZUKV (ORCPT ); Wed, 26 Jun 2019 16:10:21 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:53740 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbfFZUKV (ORCPT ); Wed, 26 Jun 2019 16:10:21 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5QK9CW2179945; Wed, 26 Jun 2019 20:09:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=+gwSshYVuRmT5asPtC7EtaE2rYMHlZqALtRin1Cfo7s=; b=2ZHWFR7pAG2Yuh0PbkMJHrIi7GyLlBAEa5ORNAdXauj4d9vcPTDtBbq7CqVDPmFVobs3 GgBH3eiJuuSLmTgF9TinWPTP3TXaBz1NssvreqJ8PSHAytFP0AJBvwXo8nHrcKXTYR9v NqqKi2YtNqBMhbqy2Vj5hohOqrNGa4un0gcvaRxAQmfLpFjC8NgtLBN/Bq+ZtR8uOMGr ByeH+iXcEyha5m4wmSMbLJkQD36TR4Jgk5oAwCofsgjJvKFsTcd/LxvE1Jw+fCljP1OK F+Ud/nN0jq85GS8iDF/RvUN8ZTR57+dpHjzbIZQvS7qAmavhgPkcRdqLE3mI2skGt+Ld VQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2t9brtcg0k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jun 2019 20:09:49 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5QK8697128008; Wed, 26 Jun 2019 20:09:49 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2t99f4ne1q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jun 2019 20:09:49 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5QK9mAH028224; Wed, 26 Jun 2019 20:09:48 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 26 Jun 2019 13:09:47 -0700 Date: Wed, 26 Jun 2019 13:09:46 -0700 From: "Darrick J. Wong" To: Andreas Gruenbacher Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH v2 3/3] iomap: fix page_done callback for short writes Message-ID: <20190626200946.GK5171@magnolia> References: <20190626132335.14809-1-agruenba@redhat.com> <20190626132335.14809-3-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190626132335.14809-3-agruenba@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9300 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906260233 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9300 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906260233 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jun 26, 2019 at 03:23:35PM +0200, Andreas Gruenbacher wrote: > When we truncate a short write to have it retried, pass the truncated > length to the page_done callback instead of the full length. > > Signed-off-by: Andreas Gruenbacher LGTM, Reviewed-by: Darrick J. Wong --D > --- > fs/iomap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/iomap.c b/fs/iomap.c > index 97569064faaa..9a9d016b2782 100644 > --- a/fs/iomap.c > +++ b/fs/iomap.c > @@ -803,7 +803,7 @@ iomap_write_end(struct inode *inode, loff_t pos, unsigned len, > if (old_size < pos) > pagecache_isize_extended(inode, old_size, pos); > if (page_ops && page_ops->page_done) > - page_ops->page_done(inode, pos, copied, page, iomap); > + page_ops->page_done(inode, pos, ret, page, iomap); > put_page(page); > > if (ret < len) > -- > 2.20.1 >