From: Al Viro <viro@zeniv.linux.org.uk>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fsdevel@vger.kernel.org,
David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] vfs: move_mount: reject moving kernel internal mounts
Date: Sat, 29 Jun 2019 21:39:16 +0100 [thread overview]
Message-ID: <20190629203916.GV17978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190629202744.12396-1-ebiggers@kernel.org>
On Sat, Jun 29, 2019 at 01:27:44PM -0700, Eric Biggers wrote:
> @@ -2600,7 +2600,7 @@ static int do_move_mount(struct path *old_path, struct path *new_path)
> if (attached && !check_mnt(old))
> goto out;
>
> - if (!attached && !(ns && is_anon_ns(ns)))
> + if (!attached && !(ns && ns != MNT_NS_INTERNAL && is_anon_ns(ns)))
> goto out;
>
> if (old->mnt.mnt_flags & MNT_LOCKED)
*UGH*
Applied, but that code is getting really ugly ;-/
next prev parent reply other threads:[~2019-06-29 20:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 10:47 general protection fault in do_move_mount (2) syzbot
2019-06-18 14:02 ` Al Viro
2019-06-24 9:28 ` Dmitry Vyukov
2019-06-29 20:27 ` [PATCH] vfs: move_mount: reject moving kernel internal mounts Eric Biggers
2019-06-29 20:39 ` Al Viro [this message]
2019-07-01 1:08 ` Al Viro
2019-07-01 15:43 ` Eric Biggers
2019-07-01 7:38 ` David Howells
2019-07-01 11:19 ` Al Viro
2019-07-01 16:45 ` Eric Biggers
2019-07-01 18:22 ` Al Viro
2019-07-01 19:20 ` Al Viro
2019-07-02 18:22 ` Eric Biggers
2019-07-09 19:40 ` Eric Biggers
2019-07-09 20:54 ` Al Viro
2019-07-10 3:23 ` 6 new syscalls without tests (was: [PATCH] vfs: move_mount: reject moving kernel internal mounts) Eric Biggers
2019-07-05 9:01 ` move_mount.2 David Howells
2019-06-29 20:39 ` general protection fault in do_move_mount (2) Eric Biggers
2019-07-01 14:59 ` Dmitry Vyukov
2019-07-01 15:18 ` Eric Biggers
2019-07-05 12:17 ` Dmitry Vyukov
2019-07-05 13:02 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190629203916.GV17978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).