From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E6F1C73C65 for ; Wed, 10 Jul 2019 01:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBB782073D for ; Wed, 10 Jul 2019 01:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562722561; bh=G8l0qfV1rZedrGf3CKStAk7W/ybMot/6ylczZwVxTbA=; h=Date:From:To:Subject:References:In-Reply-To:List-ID:From; b=rnES9k3iwKvjQXvh89K99MQJMu1thtRjP2atiIV0qZWqngqkhR8mkgKtL4zxtM7bk 1ePaPmpXO+zzdjTrUzQeVvmF/961WTNb2xBr9s7gBrQfIAqnsaYWom2Nasctgg7/TR dGwRAYQoKr9pyqU1DdAGFVIK6/bx04W7W2ilHad4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726896AbfGJBf4 (ORCPT ); Tue, 9 Jul 2019 21:35:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:42914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726324AbfGJBf4 (ORCPT ); Tue, 9 Jul 2019 21:35:56 -0400 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65CD120693; Wed, 10 Jul 2019 01:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562722555; bh=G8l0qfV1rZedrGf3CKStAk7W/ybMot/6ylczZwVxTbA=; h=Date:From:To:Subject:References:In-Reply-To:From; b=GGdkVqlp13SW1vC82uEbUUFXMVHfk8oghJOxj7T5R1cgPGfQ5gD5yqxpwOENPjFjp MVAjmiyFJ85/CNwguHy21F2lkDSp7Go2jOVlaaAaEnd1/imphKo98ngsUNJmiteHZC MPU1UkMMRTVcd/yChGW5UWTNFLeU1oo95AjW4bGU= Date: Tue, 9 Jul 2019 18:35:53 -0700 From: Eric Biggers To: David Howells , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] KEYS: Replace uid/gid/perm permissions checking with an ACL Message-ID: <20190710013553.GC7973@sol.localdomain> Mail-Followup-To: David Howells , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <155862710003.24863.11807972177275927370.stgit@warthog.procyon.org.uk> <155862710731.24863.14013725058582750710.stgit@warthog.procyon.org.uk> <20190710011559.GA7973@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190710011559.GA7973@sol.localdomain> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jul 09, 2019 at 06:16:01PM -0700, Eric Biggers wrote: > On Thu, May 23, 2019 at 04:58:27PM +0100, David Howells wrote: > > Replace the uid/gid/perm permissions checking on a key with an ACL to allow > > the SETATTR and SEARCH permissions to be split. This will also allow a > > greater range of subjects to represented. > > > > This patch broke 'keyctl new_session', and hence broke all the fscrypt tests: > > $ keyctl new_session > keyctl_session_to_parent: Permission denied > > Output of 'keyctl show' is > > $ keyctl show > Session Keyring > 605894913 --alswrv 0 0 keyring: _ses > 189223103 ----s-rv 0 0 \_ user: invocation_id > > - Eric ... and this also broke loading in-kernel X.509 certificates. See the other thread: https://lore.kernel.org/lkml/27671.1562384658@turing-police/T/#u - Eric