From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DATE_IN_PAST_06_12, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BA55C74A4D for ; Thu, 11 Jul 2019 08:10:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3428C21537 for ; Thu, 11 Jul 2019 08:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728207AbfGKIKg (ORCPT ); Thu, 11 Jul 2019 04:10:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:38512 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727929AbfGKIKg (ORCPT ); Thu, 11 Jul 2019 04:10:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F3036AD4D; Thu, 11 Jul 2019 08:10:34 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id B5BB21E43B7; Wed, 10 Jul 2019 22:26:47 +0200 (CEST) Date: Wed, 10 Jul 2019 22:26:47 +0200 From: Jan Kara To: Matthew Wilcox Cc: Jan Kara , Dan Williams , linux-fsdevel , Boaz Harrosh , stable , Robert Barror , Seema Pandit , linux-nvdimm , Linux Kernel Mailing List Subject: Re: [PATCH] dax: Fix missed PMD wakeups Message-ID: <20190710202647.GA7269@quack2.suse.cz> References: <20190703195302.GJ1729@bombadil.infradead.org> <20190704032728.GK1729@bombadil.infradead.org> <20190704165450.GH31037@quack2.suse.cz> <20190704191407.GM1729@bombadil.infradead.org> <20190705191004.GC32320@bombadil.infradead.org> <20190710190204.GB14701@quack2.suse.cz> <20190710201539.GN32320@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190710201539.GN32320@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed 10-07-19 13:15:39, Matthew Wilcox wrote: > On Wed, Jul 10, 2019 at 09:02:04PM +0200, Jan Kara wrote: > > +#define DAX_ENTRY_CONFLICT dax_make_entry(pfn_to_pfn_t(1), DAX_EMPTY) > > I was hoping to get rid of DAX_EMPTY ... it's almost unused now. Once > we switch to having a single DAX_LOCK value instead of a single bit, > I think it can go away, freeing up two bits. > > If you really want a special DAX_ENTRY_CONFLICT, I think we can make > one in the 2..4094 range. > > That aside, this looks pretty similar to the previous patch I sent, so > if you're now happy with this, let's add > > #define XA_DAX_CONFLICT_ENTRY xa_mk_internal(258) > > to xarray.h and do it that way? Yeah, that would work for me as well. The chosen value for DAX_ENTRY_CONFLICT was pretty arbitrary. Or we could possibly use: #define DAX_ENTRY_CONFLICT XA_ZERO_ENTRY so that we don't leak DAX-specific internal definition into xarray.h? Honza -- Jan Kara SUSE Labs, CR