From: Alexey Dobriyan <email@example.com> To: Alexey Izbyshev <firstname.lastname@example.org> Cc: Oleg Nesterov <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH] proc: Fix uninitialized byte read in get_mm_cmdline() Date: Sat, 13 Jul 2019 10:26:06 +0300 Message-ID: <20190713072606.GA23167@avx2> (raw) In-Reply-To: <email@example.com> On Fri, Jul 12, 2019 at 09:43:03PM +0300, Alexey Izbyshev wrote: > On 7/12/19 8:46 PM, Alexey Dobriyan wrote: > > On Fri, Jul 12, 2019 at 06:36:26PM +0200, Oleg Nesterov wrote: > >> On 07/12, Alexey Izbyshev wrote: > >>> > >>> --- a/fs/proc/base.c > >>> +++ b/fs/proc/base.c > >>> @@ -275,6 +275,8 @@ static ssize_t get_mm_cmdline(struct mm_struct *mm, char __user *buf, > >>> if (got <= offset) > >>> break; > >>> got -= offset; > >>> + if (got < size) > >>> + size = got; > >> > >> Acked-by: Oleg Nesterov <firstname.lastname@example.org> > > > > The proper fix to all /proc/*/cmdline problems is to revert > > > > f5b65348fd77839b50e79bc0a5e536832ea52d8d > > proc: fix missing final NUL in get_mm_cmdline() rewrite > > > > 5ab8271899658042fabc5ae7e6a99066a210bc0e > > fs/proc: simplify and clarify get_mm_cmdline() function > > > Should this be interpreted as an actual suggestion to revert the patches, > fix the conflicts, test and submit them, or is this more like thinking out > loud? Of course! Do you have a reproducer? > In the former case, will it be OK for long term branches? For everyone. If a rewrite causes 1 bug, 1 user visible change and a infoleak, it is called revert. > get_mm_cmdline() does seem easier to read for me before 5ab8271899658042. > But it also has different semantics in corner cases, for example: All semantics changes are recent. > - If there is no NUL at arg_end-1, it reads only the first string in > the combined arg/env block, and doesn't terminate it with NUL. That's because fixed-length /proc/*/cmdline did that. > - If there is any problem with access_remote_vm() or copy_to_user(), > it returns -EFAULT even if some data were copied to userspace. > > On the other hand, 5ab8271899658042 was merged not too long ago (about a year), > so it's possible that the current semantics isn't heavily relied upon.
next prev parent reply index Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-12 16:09 Alexey Izbyshev 2019-07-12 16:36 ` Oleg Nesterov 2019-07-12 17:46 ` Alexey Dobriyan 2019-07-12 18:43 ` Alexey Izbyshev 2019-07-12 21:17 ` Jakub Jankowski 2019-07-12 22:29 ` Alexey Izbyshev 2019-07-13 7:26 ` Alexey Dobriyan [this message] 2019-07-13 14:09 ` Alexey Izbyshev
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190713072606.GA23167@avx2 \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Fsdevel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \ email@example.com firstname.lastname@example.org public-inbox-index linux-fsdevel Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel AGPL code for this site: git clone https://public-inbox.org/ public-inbox