From: Johannes Thumshirn <jthumshirn@suse.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Damien Le Moal <damien.lemoal@wdc.com>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH RFC] fs: New zonefs file system
Date: Mon, 15 Jul 2019 08:57:45 +0200 [thread overview]
Message-ID: <20190715065745.GA4495@x250> (raw)
In-Reply-To: <20190715011935.GM7689@dread.disaster.area>
On Mon, Jul 15, 2019 at 11:19:35AM +1000, Dave Chinner wrote:
[...]
> > +/*
> > + * Open a file.
> > + */
> > +static int zonefs_file_open(struct inode *inode, struct file *file)
> > +{
> > + /*
> > + * Note: here we can do an explicit open of the file zone,
> > + * on the first open of the inode. The explicit close can be
> > + * done on the last release (close) call for the inode.
> > + */
> > +
> > + return generic_file_open(inode, file);
> > +}
>
> Why is a wrapper needed for this?
AFAIR this is a left over from an older patch of me where an open of a
sequential only zone automagically appended O_APPEND, but this broke all kinds
of assumptions user-space did so Damien ripped it out again. So yes the
wrapper can go as well.
Byte,
Johannes
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-07-15 6:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 3:00 [PATCH RFC] fs: New zonefs file system Damien Le Moal
2019-07-12 8:00 ` Johannes Thumshirn
2019-07-12 8:31 ` Damien Le Moal
2019-07-12 8:47 ` Johannes Thumshirn
2019-07-12 17:10 ` Viacheslav Dubeyko
2019-07-12 22:56 ` Damien Le Moal
2019-07-15 16:54 ` Viacheslav Dubeyko
2019-07-15 23:53 ` Damien Le Moal
2019-07-16 16:51 ` Viacheslav Dubeyko
2019-07-18 0:57 ` Damien Le Moal
2019-07-15 1:19 ` Dave Chinner
2019-07-15 6:57 ` Johannes Thumshirn [this message]
2019-07-16 11:21 ` Damien Le Moal
2019-07-18 14:11 ` Jeff Moyer
2019-07-18 23:02 ` Damien Le Moal
2019-07-19 14:25 ` Jeff Moyer
2019-07-20 1:07 ` Damien Le Moal
2019-07-22 0:12 ` Dave Chinner
2019-07-20 7:15 ` Damien Le Moal
2019-07-22 0:04 ` Dave Chinner
2019-07-22 0:09 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715065745.GA4495@x250 \
--to=jthumshirn@suse.de \
--cc=damien.lemoal@wdc.com \
--cc=david@fromorbit.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).