From: Andrew Morton <akpm@linux-foundation.org>
To: Roman Penyaev <rpenyaev@suse.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Azat Khuzhin <azat@libevent.org>, Eric Wong <e@80x24.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/14] epoll: support pollable epoll from userspace
Date: Fri, 26 Jul 2019 16:22:08 -0700 [thread overview]
Message-ID: <20190726162208.0a9a244d41d9384fb94d9210@linux-foundation.org> (raw)
In-Reply-To: <20190611145458.9540-1-rpenyaev@suse.de>
On Tue, 11 Jun 2019 16:54:44 +0200 Roman Penyaev <rpenyaev@suse.de> wrote:
> Hi all,
>
> This is v4 which introduces pollable epoll from userspace.
A nicely presented patchset.
>
> ...
>
> ** Measurements
>
> In order to measure polling from userspace libevent was modified [1] and
> bench_http benchmark (client and server) was used:
>
> o EPOLLET, original epoll:
>
> 20000 requests in 0.551306 sec. (36277.49 throughput)
> Each took about 5.54 msec latency
> 1600000bytes read. 0 errors.
>
> o EPOLLET + polling from userspace:
>
> 20000 requests in 0.475585 sec. (42053.47 throughput)
> Each took about 4.78 msec latency
> 1600000bytes read. 0 errors.
It would be useful to include some words which describe the
significance of this to real-world userspace. If a real application is
sped up 0.000000001% then this isn't very exciting ;)
>
> ...
>
> epoll_create2(EPOLL_USERPOLL, max_items_nr);
So a manpage update is due. It would be useful to send this along
while people are reviewing the code changes. Please cc Michael Kerrisk
and linux-man@vger.kernel.org on everything.
>
> arch/alpha/kernel/syscalls/syscall.tbl | 2 +
> arch/arm/tools/syscall.tbl | 1 +
> arch/arm64/include/asm/unistd.h | 2 +-
> arch/arm64/include/asm/unistd32.h | 2 +
> arch/ia64/kernel/syscalls/syscall.tbl | 2 +
> arch/m68k/kernel/syscalls/syscall.tbl | 2 +
> arch/microblaze/kernel/syscalls/syscall.tbl | 1 +
> arch/mips/kernel/syscalls/syscall_n32.tbl | 2 +
> arch/mips/kernel/syscalls/syscall_n64.tbl | 2 +
> arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +
> arch/parisc/kernel/syscalls/syscall.tbl | 2 +
> arch/powerpc/kernel/syscalls/syscall.tbl | 2 +
> arch/s390/kernel/syscalls/syscall.tbl | 2 +
> arch/sh/kernel/syscalls/syscall.tbl | 2 +
> arch/sparc/kernel/syscalls/syscall.tbl | 2 +
> arch/x86/entry/syscalls/syscall_32.tbl | 1 +
> arch/x86/entry/syscalls/syscall_64.tbl | 1 +
> arch/xtensa/kernel/syscalls/syscall.tbl | 1 +
> fs/eventpoll.c | 925 ++++++++++++++++--
Wow.
> include/linux/syscalls.h | 1 +
> include/uapi/asm-generic/unistd.h | 4 +-
> include/uapi/linux/eventpoll.h | 47 +-
> kernel/sys_ni.c | 1 +
> tools/testing/selftests/Makefile | 1 +
> tools/testing/selftests/uepoll/.gitignore | 1 +
> tools/testing/selftests/uepoll/Makefile | 16 +
> .../uepoll/atomic-builtins-support.c | 13 +
> tools/testing/selftests/uepoll/uepoll-test.c | 603 ++++++++++++
There's a lot to look at here. I guess now would be a good time to
refresh and resend.
next prev parent reply other threads:[~2019-07-26 23:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 14:54 [PATCH v4 00/14] epoll: support pollable epoll from userspace Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 01/14] epoll: move private helpers from a header to the source Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 02/14] epoll: introduce user structures for polling from userspace Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 03/14] epoll: allocate user header and user events ring " Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 04/14] epoll: some sanity flags checks for epoll syscalls " Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 05/14] epoll: offload polling to a work in case of epfd polled " Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 06/14] epoll: introduce helpers for adding/removing events to uring Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 07/14] epoll: call ep_add_event_to_uring() from ep_poll_callback() Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 08/14] epoll: support polling from userspace for ep_insert() Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 09/14] epoll: support polling from userspace for ep_remove() Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 10/14] epoll: support polling from userspace for ep_modify() Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 11/14] epoll: support polling from userspace for ep_poll() Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 12/14] epoll: support mapping for epfd when polled from userspace Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 13/14] epoll: implement epoll_create2() syscall Roman Penyaev
2019-06-11 14:54 ` [PATCH v4 14/14] kselftest: add uepoll-test which tests polling from userspace Roman Penyaev
2019-07-26 23:22 ` Andrew Morton [this message]
2019-07-27 17:16 ` [PATCH v4 00/14] epoll: support pollable epoll " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726162208.0a9a244d41d9384fb94d9210@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=azat@libevent.org \
--cc=e@80x24.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rpenyaev@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).