From: Carlos Maiolino <cmaiolino@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: hch@lst.de, adilger@dilger.ca, jaegeuk@kernel.org,
darrick.wong@oracle.com, miklos@szeredi.hu, rpeterso@redhat.com,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 0/9 V4] New ->fiemap infrastructure and ->bmap removal
Date: Fri, 2 Aug 2019 12:20:43 +0200 [thread overview]
Message-ID: <20190802102042.7oepvmqteh6jcxdq@pegasus.maiolino.io> (raw)
In-Reply-To: <20190731141245.7230-1-cmaiolino@redhat.com>
On Wed, Jul 31, 2019 at 04:12:36PM +0200, Carlos Maiolino wrote:
> Hi.
Please, disconsider this patchset, I wrongly rebased it and there are many
missing changes that should be done to properly rebase it agains 5.3
>
> This is the 4th version of the complete series with the goal to deprecate and
> eventually remove ->bmap() interface, in lieu of FIEMAP.
>
> Besides the rebase of the patchset against latest Linus's tree, the only changes
> in this patchset regarding to the previous version, are concentrated in patches
> 4/9 and 8/9.
>
> In patch 4 (fibmap: Use bmap instead of ->bmap method in ioctl_fibmap), the
> difference compared with previous version, is a change in ioclt_fibmap() return
> value, I spotted while testing this new version with filesystems using data
> inlined in inodes. It now returns 0 in case of error instead an error value,
> otherwise it would be an user interface change.
>
>
> In patch 8 (Use FIEMAP for FIBMAP calls), there are minor changes regarding V3.
> It just contains a coding style fix pointed by Andreas in the previous version,
> but now, it also include changes to all filesystems which supports both FIEMAP
> and FIBMAP, and need some sort of special handling (like inlined data, reflinked
> inodes, etc).
>
> Again, Patch 9 is xfs-specific removal of ->bmap() interface, without any
> changes compared to the previous version.
>
>
>
> I do apologize for taking so long to rework this patchset, I've got busy with
> other stuff.
>
> Comments are appreciated, specially regarding if the error values returned by
> ioctl_fibmap() make sense.
>
>
> Cheers
>
> Carlos Maiolino (9):
> fs: Enable bmap() function to properly return errors
> cachefiles: drop direct usage of ->bmap method.
> ecryptfs: drop direct calls to ->bmap
> fibmap: Use bmap instead of ->bmap method in ioctl_fibmap
> fs: Move start and length fiemap fields into fiemap_extent_info
> iomap: Remove length and start fields from iomap_fiemap
> fiemap: Use a callback to fill fiemap extents
> Use FIEMAP for FIBMAP calls
> xfs: Get rid of ->bmap
>
> drivers/md/md-bitmap.c | 16 ++++--
> fs/bad_inode.c | 3 +-
> fs/btrfs/inode.c | 5 +-
> fs/cachefiles/rdwr.c | 27 ++++-----
> fs/ecryptfs/mmap.c | 16 ++----
> fs/ext2/ext2.h | 3 +-
> fs/ext2/inode.c | 6 +-
> fs/ext4/ext4.h | 3 +-
> fs/ext4/extents.c | 15 +++--
> fs/f2fs/data.c | 15 ++++-
> fs/f2fs/f2fs.h | 3 +-
> fs/gfs2/inode.c | 9 ++-
> fs/hpfs/file.c | 4 +-
> fs/inode.c | 105 +++++++++++++++++++++++++++++----
> fs/ioctl.c | 128 ++++++++++++++++++++++++++---------------
> fs/iomap.c | 40 ++-----------
> fs/jbd2/journal.c | 22 ++++---
> fs/nilfs2/inode.c | 5 +-
> fs/nilfs2/nilfs.h | 3 +-
> fs/ocfs2/extent_map.c | 13 ++++-
> fs/ocfs2/extent_map.h | 3 +-
> fs/overlayfs/inode.c | 5 +-
> fs/xfs/xfs_aops.c | 24 --------
> fs/xfs/xfs_iops.c | 19 +++---
> fs/xfs/xfs_trace.h | 1 -
> include/linux/fs.h | 33 +++++++----
> include/linux/iomap.h | 2 +-
> mm/page_io.c | 11 ++--
> 28 files changed, 320 insertions(+), 219 deletions(-)
>
> --
> 2.20.1
>
--
Carlos
prev parent reply other threads:[~2019-08-02 10:20 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 14:12 [PATCH 0/9 V4] New ->fiemap infrastructure and ->bmap removal Carlos Maiolino
2019-07-31 14:12 ` [PATCH 1/9] fs: Enable bmap() function to properly return errors Carlos Maiolino
2019-07-31 14:12 ` [PATCH 2/9] cachefiles: drop direct usage of ->bmap method Carlos Maiolino
2019-07-31 14:12 ` [PATCH 3/9] ecryptfs: drop direct calls to ->bmap Carlos Maiolino
2019-07-31 14:12 ` [PATCH 4/9] fibmap: Use bmap instead of ->bmap method in ioctl_fibmap Carlos Maiolino
2019-07-31 23:12 ` Darrick J. Wong
2019-08-02 9:19 ` Carlos Maiolino
2019-08-02 15:14 ` Darrick J. Wong
2019-08-05 10:27 ` Carlos Maiolino
2019-08-05 15:12 ` Darrick J. Wong
2019-08-06 5:38 ` Christoph Hellwig
2019-08-06 12:07 ` Carlos Maiolino
2019-08-06 14:48 ` Darrick J. Wong
2019-08-08 7:17 ` Carlos Maiolino
2019-08-06 12:02 ` Carlos Maiolino
2019-08-06 22:41 ` Luis Chamberlain
2019-08-07 14:42 ` Darrick J. Wong
2019-08-08 7:12 ` Carlos Maiolino
2019-08-08 18:53 ` Andreas Dilger
2019-08-19 10:10 ` Carlos Maiolino
2019-07-31 14:12 ` [PATCH 5/9] fs: Move start and length fiemap fields into fiemap_extent_info Carlos Maiolino
2019-07-31 23:28 ` Darrick J. Wong
2019-08-02 9:51 ` Carlos Maiolino
2019-08-02 15:15 ` Darrick J. Wong
2019-08-05 9:40 ` Carlos Maiolino
2019-08-06 5:39 ` Christoph Hellwig
2019-07-31 14:12 ` [PATCH 6/9] iomap: Remove length and start fields from iomap_fiemap Carlos Maiolino
2019-07-31 23:24 ` Darrick J. Wong
2019-07-31 14:12 ` [PATCH 7/9] fiemap: Use a callback to fill fiemap extents Carlos Maiolino
2019-07-31 23:26 ` Darrick J. Wong
2019-07-31 14:12 ` [PATCH 8/9] Use FIEMAP for FIBMAP calls Carlos Maiolino
2019-07-31 23:22 ` Darrick J. Wong
2019-07-31 23:31 ` Darrick J. Wong
2019-08-02 13:52 ` Carlos Maiolino
2019-08-06 5:41 ` Christoph Hellwig
2019-08-02 13:48 ` Carlos Maiolino
2019-08-02 15:29 ` Darrick J. Wong
2019-08-05 10:38 ` Carlos Maiolino
2019-08-06 5:46 ` Christoph Hellwig
2019-07-31 14:12 ` [PATCH 9/9] xfs: Get rid of ->bmap Carlos Maiolino
2019-07-31 23:30 ` Darrick J. Wong
2019-08-02 10:20 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802102042.7oepvmqteh6jcxdq@pegasus.maiolino.io \
--to=cmaiolino@redhat.com \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).