From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=pn73=WC=vger.kernel.org=linux-fsdevel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 39360C433FF
	for <linux-fsdevel@archiver.kernel.org>; Tue,  6 Aug 2019 05:33:44 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 1B4FB20665
	for <linux-fsdevel@archiver.kernel.org>; Tue,  6 Aug 2019 05:33:44 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731658AbfHFFdn (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Tue, 6 Aug 2019 01:33:43 -0400
Received: from verein.lst.de ([213.95.11.211]:53237 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726077AbfHFFdn (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 6 Aug 2019 01:33:43 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id E5E7068BFE; Tue,  6 Aug 2019 07:33:39 +0200 (CEST)
Date:   Tue, 6 Aug 2019 07:33:39 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Andreas Gruenbacher <agruenba@redhat.com>
Cc:     "Darrick J. Wong" <darrick.wong@oracle.com>,
        Christoph Hellwig <hch@infradead.org>,
        linux-xfs@vger.kernel.org,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/6] iomap: copy the xfs writeback code to iomap.c
Message-ID: <20190806053339.GF13409@lst.de>
References: <156444945993.2682261.3926017251626679029.stgit@magnolia> <156444947277.2682261.14371480217831737439.stgit@magnolia> <CAHc6FU6Q5gz-i9DmdXEqNbc4f3=U7CKryb2+ETO1U1yR3r0hDg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHc6FU6Q5gz-i9DmdXEqNbc4f3=U7CKryb2+ETO1U1yR3r0hDg@mail.gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-fsdevel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

Hi Andreas,

any chance you could trim your quote to the relevant parts?

On Sun, Aug 04, 2019 at 04:59:25PM +0200, Andreas Gruenbacher wrote:
> > +       /*
> > +        * File systems can perform actions at submit time and/or override
> > +        * the end_io handler here for complex operations like copy on write
> > +        * extent manipulation or unwritten extent conversions.
> > +        */
> > +       if (wpc->ops->submit_ioend)
> > +               error = wpc->ops->submit_ioend(ioend, error);
> 
> I think we only want to call submit_ioend here if error isn't set already.

No, we need to call it even with an error so that the file system can
override the bi_end_io handler, which bio_endio ends up calling even
for the error case.

Maybe the comment above could use an update to make that more clear.