From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE5CC31E40 for ; Tue, 6 Aug 2019 17:03:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B3642075B for ; Tue, 6 Aug 2019 17:03:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b="E24UfZNd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387955AbfHFRDQ (ORCPT ); Tue, 6 Aug 2019 13:03:16 -0400 Received: from sonic301-22.consmr.mail.ir2.yahoo.com ([77.238.176.99]:34461 "EHLO sonic301-22.consmr.mail.ir2.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732996AbfHFRDQ (ORCPT ); Tue, 6 Aug 2019 13:03:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1565110994; bh=OGfEqfx+PU4InM0VSbOYRNhJFzEA/rXojevv3mMEsbI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=E24UfZNd5y/93bIO8AIK1WRL5l3AvfcVQd++GnimXLA4gR252vHsJi8k20+oURzT9w3wS92yBC/DDjRFRS8YCdg0tAJAta6BEqaj25S18QcJzGxgwFJ8x/zEn6TGVWcErkq66KW4SS109tfLATR+tTPZzzAjN47ErRJyhPQjt8WrCTp1u2ILIXcPYMhf46fJksOYnJ9Mwpz62UYBK27V2PJRIqsU+Xyi50JGMntJ95v6ct6VF0xAUyT9e6k5KsABHuOsvTCdR78uqQLZVY3b7qL/awMnptKyM0TIaZBRKJMtwO4uhyAK2z7G1WcS2pu1y+gRANlCTFItOYh4bkgeBg== X-YMail-OSG: sl1gkSwVM1mlHDEiCdaH5dj7rsgViEgTQ3a6APzIjZvHoF1PNh8AdYZocdONKXb DehHMC3hV8mbP2YRe6_SnmdQQtkOXiuatzZxsjswEf.dHL9RDFe52j3Ea.QU29gtRweDu7id2oKj hXXXElssWDQgY.XnofRaJm.RSJ2sFha5tiCVB8Nn_WrrGaZdX_Jqp2U8IxRQwBYaoxrXWp5J5tcE xYrjyrhQD0exM2ILMUpC4YQUPCeJYkdmTHhUC5vrgeT9Vzufc2V3.5GQCz84d7tugwqfGLUB3sxs s95K0Rn81hYEjC0wfFNwDC4H_VX_HUp4UJqFcwiaGkIAg8HRdaAUB.k6rF46KxvOlobREg3nGUsY mBRyWi0gPKRhJdk946XQ4TbieDTjNwUUmORU7PKqkefgBoBEJWSgD2VySrTya1ZAVZoJr6EE8pXT gBUQ87pm4doEnbtWwfM9XLJhaouK2jKB6fhWp7NxDiYOIQNer8_my3FtsUbtxS584m462LYqEJ6f 4KrKgQPr534DA.p5fhxf6QbVPIppQMsZ5WPigBeajM9KmLbcmaMSQue2XaxHN4jwym_L6Owdman3 NRlXrxqOOxfQl5ENsEe7AcvIOjXWQ1LD0BEkmB61nUwa2zh5jDnbCn1HM4LIssrWO72z_OjydP3K vC1ARwrEbZUllkReaxbmnk7PEQY2bd1r2Ya0NcSQ9Fem5pfrNGVQy5QfdCOcPbbWdHt4GiDKQyn0 X3grpvJkl9QTKL4oP.G6D1suJaS2OLkFs8rKEKP4Xell0qSBC10f55SY1bQPzzLr7Mr6cTnsTxr3 VkIz3d8TnFi8bVFDOtazRIsYNigMp3ohRsTf9FwSDRK7SblzKBF8bCoFbjDwbBPrEQLHwjeFFjee 0ljSMjbIwfO_7RJq1oHK3NFTYo5_2n23HDeLukA2E2xkYQOOgtz_s4kSq0kqbtTZX9vkSFHRbV94 uKQCtyV_ZEjLuyU.MCs2FhejKDQxoIJGUFYbFNMU9mXVX.iP_AJjv.1n.9s8H5dgk2HaeXlBmbQ0 MuzYGTPsK6NIkofKI6bIxSVF1BfLyKjVBOlO1cQJ2TBGcLcyFrao6jAMC4iMOa9oTR5JlxZGh5yx k870EeUkAb1Hh3smqInaGEMA6u.FQErg037R3OTAJt15QCoKSFboc2d1EKe4Ywnxqk3Pq1CS8EZf hC7Thr59WMZjgZUzlmngacmH5IgHTpqRD_BGXn50aYE_bLCy8DRrm_fIMDqDQMR43gG4YiYf01Vc k68WnBIHCfPMWRieLByE9LBAWCw-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Tue, 6 Aug 2019 17:03:14 +0000 Received: by smtp406.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID af769fc35dd430e77b6ac1739d1acdf0; Tue, 06 Aug 2019 17:03:11 +0000 (UTC) Date: Wed, 7 Aug 2019 01:02:58 +0800 From: Gao Xiang To: Stephen Rothwell Cc: Gao Xiang , devel@driverdev.osuosl.org, linux-erofs@lists.ozlabs.org, Theodore Ts'o , "Darrick J . Wong" , Greg Kroah-Hartman , Jan Kara , Amir Goldstein , Dave Chinner , David Sterba , LKML , Christoph Hellwig , Miao Xie , Alexander Viro , Pavel Machek , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , Andrew Morton , Linus Torvalds Subject: Re: [PATCH RFC] erofs: move erofs out of staging Message-ID: <20190806170252.GB29093@hsiangkao-HP-ZHAN-66-Pro-G1> References: <20190806094925.228906-1-gaoxiang25@huawei.com> <20190807013423.02fd6990@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190807013423.02fd6990@canb.auug.org.au> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Stephen, On Wed, Aug 07, 2019 at 01:34:23AM +1000, Stephen Rothwell wrote: > Hi Gao, > > One small suggestion: just remove the file names from the comments at > the top of the files rather than change them to reflect that they have > moved. We can usually tell the name of a file by its name :-) Thanks for your reply :) For this part, EROFS initially followed what ext4, f2fs, even fsverity do, https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/ext4/namei.c https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/f2fs/namei.c https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/tree/fs/verity/verify.c?h=fsverity I think I can remove these filenames as you suggested in the next version. I thought these are some common practice and there is no obvious right or wrong of this kind of stuffs. Thanks, Gao Xiang > > -- > Cheers, > Stephen Rothwell