From: Christoph Hellwig <hch@infradead.org>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH 1/3] ext4: return the extent cache information via fiemap
Date: Sun, 11 Aug 2019 23:47:28 -0700 [thread overview]
Message-ID: <20190812064728.GA22302@infradead.org> (raw)
In-Reply-To: <20190811161508.GA5878@mit.edu>
On Sun, Aug 11, 2019 at 12:15:08PM -0400, Theodore Y. Ts'o wrote:
> > Nak. No weird fs specific fiemap flags that aren't even in the uapi
> > header. Please provide your own debug only interface.
>
> I can understand why you don't like this from the principle of the
> thing.
I think mixing up in-kernel temporary state with the on-disk layout
is a bad idea, yes. I think it is an even worse idea to try to sneak
it in without API review in an undocumented fashion.
>
> I'll create my own ioctl, and make a copy of ioctl_fiemap() into ext4
> and modify it for my needs. I was trying to avoid needing to do that,
> since there is plenty of space in the fiemap flags to carve out space
> for file-specific specific flags, and avoiding making extra copies of
> code for the purposes of reuse weighed more heavily than "no
> fs-specific fiemap flags".
I think dumping your internal state is a candidate for debugs, not
a copy of ioctl_fiemap.
prev parent reply other threads:[~2019-08-12 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190809181831.10618-1-tytso@mit.edu>
2019-08-10 7:33 ` [PATCH 1/3] ext4: return the extent cache information via fiemap Christoph Hellwig
2019-08-11 16:15 ` Theodore Y. Ts'o
2019-08-12 6:47 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812064728.GA22302@infradead.org \
--to=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).