From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22ACC31E40 for ; Tue, 13 Aug 2019 03:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AA89206C1 for ; Tue, 13 Aug 2019 03:40:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727221AbfHMDkx (ORCPT ); Mon, 12 Aug 2019 23:40:53 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:3086 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726556AbfHMDkw (ORCPT ); Mon, 12 Aug 2019 23:40:52 -0400 Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.54]) by Forcepoint Email with ESMTP id 90EE0B75969977179D59; Tue, 13 Aug 2019 11:40:50 +0800 (CST) Received: from dggeme762-chm.china.huawei.com (10.3.19.108) by DGGEMM403-HUB.china.huawei.com (10.3.20.211) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 13 Aug 2019 11:40:49 +0800 Received: from 138 (10.175.124.28) by dggeme762-chm.china.huawei.com (10.3.19.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Tue, 13 Aug 2019 11:40:49 +0800 Date: Tue, 13 Aug 2019 11:57:57 +0800 From: Gao Xiang To: Chao Yu CC: Greg Kroah-Hartman , , , LKML , , Chao Yu , Miao Xie , , "Fang Wei" Subject: Re: [PATCH 3/3] staging: erofs: xattr.c: avoid BUG_ON Message-ID: <20190813035754.GA23614@138> References: <20190813023054.73126-1-gaoxiang25@huawei.com> <20190813023054.73126-3-gaoxiang25@huawei.com> <84f50ca2-3411-36a6-049a-0d343d8df325@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <84f50ca2-3411-36a6-049a-0d343d8df325@huawei.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Originating-IP: [10.175.124.28] X-ClientProxiedBy: dggeme702-chm.china.huawei.com (10.1.199.98) To dggeme762-chm.china.huawei.com (10.3.19.108) X-CFilter-Loop: Reflected Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Chao, On Tue, Aug 13, 2019 at 11:20:22AM +0800, Chao Yu wrote: > On 2019/8/13 10:30, Gao Xiang wrote: > > Kill all the remaining BUG_ON in EROFS: > > - one BUG_ON was used to detect xattr on-disk corruption, > > proper error handling should be added for it instead; > > - the other BUG_ONs are used to detect potential issues, > > use DBG_BUGON only in (eng) debugging version. > > BTW, do we need add WARN_ON() into DBG_BUGON() to show some details function or > call stack in where we encounter the issue? Thanks for kindly review :) Agreed, it seems much better. If there are no other considerations here, I can submit another patch addressing it later or maybe we can change it in the next linux version since I'd like to focusing on moving out of staging for this round... Thanks, Gao Xiang > > > > > Signed-off-by: Gao Xiang > > Reviewed-by: Chao Yu > > Thanks,