From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 792C8C433FF for ; Wed, 14 Aug 2019 11:14:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 561342083B for ; Wed, 14 Aug 2019 11:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727266AbfHNLOj (ORCPT ); Wed, 14 Aug 2019 07:14:39 -0400 Received: from verein.lst.de ([213.95.11.211]:37169 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726265AbfHNLOj (ORCPT ); Wed, 14 Aug 2019 07:14:39 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C9E9968B05; Wed, 14 Aug 2019 13:14:35 +0200 (CEST) Date: Wed, 14 Aug 2019 13:14:35 +0200 From: Christoph Hellwig To: Carlos Maiolino Cc: linux-fsdevel@vger.kernel.org, hch@lst.de, adilger@dilger.ca, jaegeuk@kernel.org, darrick.wong@oracle.com, miklos@szeredi.hu, rpeterso@redhat.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/9] fs: Enable bmap() function to properly return errors Message-ID: <20190814111435.GB1885@lst.de> References: <20190808082744.31405-1-cmaiolino@redhat.com> <20190808082744.31405-2-cmaiolino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190808082744.31405-2-cmaiolino@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Just curious from looking this again - shoudn't the 0 block be turned into an error by the bmap() function? At least for the legacy ->bmap case so that we don't have to carry this cruft around.