From: Andrew Morton <akpm@linux-foundation.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: hch@infradead.org, tytso@mit.edu, viro@zeniv.linux.org.uk,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH RFC 3/2] fstests: check that we can't write to swap files
Date: Thu, 15 Aug 2019 14:26:03 -0700 [thread overview]
Message-ID: <20190815142603.de9f1c0d9fcc017f3237708d@linux-foundation.org> (raw)
In-Reply-To: <20190815163434.GA15186@magnolia>
On Thu, 15 Aug 2019 09:34:34 -0700 "Darrick J. Wong" <darrick.wong@oracle.com> wrote:
> While active, the media backing a swap file is leased to the kernel.
> Userspace has no business writing to it. Make sure we can't do this.
I don't think this tests the case where a file was already open for
writing and someone does swapon(that file)?
And then does swapoff(that file), when writes should start working again?
Ditto all the above, with s/open/mmap/.
Do we handle (and test!) the case where there's unwritten dirty
pagecache at the time of swapon()? Ditto pte-dirty MAP_SHARED pages?
next prev parent reply other threads:[~2019-08-15 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 16:05 [PATCH v3 0/2] vfs: make active swap files unwritable Darrick J. Wong
2019-08-15 16:05 ` [PATCH 1/2] mm: set S_SWAPFILE on blockdev swap devices Darrick J. Wong
2019-08-16 6:39 ` Christoph Hellwig
2019-08-15 16:05 ` [PATCH 2/2] vfs: don't allow writes to swap files Darrick J. Wong
2019-08-16 6:41 ` Christoph Hellwig
2019-08-16 6:48 ` Darrick J. Wong
2019-08-16 16:19 ` [PATCH v2 " Darrick J. Wong
2019-08-18 8:39 ` Christoph Hellwig
2019-08-15 16:34 ` [PATCH RFC 3/2] fstests: check that we can't write " Darrick J. Wong
2019-08-15 21:26 ` Andrew Morton [this message]
2019-08-16 2:13 ` Darrick J. Wong
2019-08-17 2:05 ` [PATCH v2 " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815142603.de9f1c0d9fcc017f3237708d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).