From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F841C3A589 for ; Thu, 15 Aug 2019 14:51:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6417B2067D for ; Thu, 15 Aug 2019 14:51:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="dU2EhV+6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733137AbfHOOvE (ORCPT ); Thu, 15 Aug 2019 10:51:04 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:43655 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731581AbfHOOvE (ORCPT ); Thu, 15 Aug 2019 10:51:04 -0400 Received: by mail-qk1-f195.google.com with SMTP id m2so1997513qkd.10 for ; Thu, 15 Aug 2019 07:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=z90nPpYO8UuUUSb9IN8rKS3L0KsgC8zXmObZdfo6ctQ=; b=dU2EhV+6EWSs1MNrZJWfU76DaiGX5NQgWL4uohTv/GZxgH6FeggKTIKZ+d/6xxWmB5 Uq7EirJG422MX6svb2pK3O0rmVD5upXZhrC0obDyAVUsClwMUccie10LZ+VusUXs6G5t Cfxm7G3duJErwOwTzL6wlTMWxPvhXqi0t55/HXZYJ0ksP5CllSxCeRSJEwA3qeLb3Mw+ H9tQF6/hs2KVjejIpKYI3tuEWzOasQMSO5OrPdyS6Tf6gZNSrPhr0d7BWVqY895GeZU7 3vhMlzFvKziDCq6pld4ycFVFRE1zOEJ/X+8kNMBCMNIgJ/nYLqTQqzhkO3QmO9Oxi/p7 z4xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=z90nPpYO8UuUUSb9IN8rKS3L0KsgC8zXmObZdfo6ctQ=; b=TvGHGdaLG4d9qQ6CHS0vEWcfS5th0DRmteryyViMI5dAvzcpnh6gu76YsBjH8GMSPC rb0vwqXb1XaNZnicStzet4vPMlfdif/BP4vy2PH+xuJcwHBWRMJvMad18s75+cL6F3xT KjM64sFxmjHc+GIRCWVlZ1GKed+MFq9hJvpljU4ly4uN3EThrMvF2mE5hrG1N8yAhPz7 azHv0gQCgA54y1m0GcKrNAYHYTRnTfHXc3JXusPF5Pyzd0bZ9FjEspwScKDerVJEJg4q yUpUFs+op3AuiAhPAoI6fASgWbGu61kkucwehVphqtOTCvyjsBiwM1ZKErX2rp1R1xp6 nAyg== X-Gm-Message-State: APjAAAUHxJLdRisHJkIst4aui46yjkJYnkZEAy68+75JmQVxLdMBokDF Oel3m8bwwyDU7KSg9O2uA7CMwQ== X-Google-Smtp-Source: APXvYqyMHfwmFKSYVNb8WeeauLH7Hep/WJZ+jheCJjAwrLvMcjUnfX6gEreyk5eeamBSEzYzpviglQ== X-Received: by 2002:a05:620a:71a:: with SMTP id 26mr4357407qkc.374.1565880663323; Thu, 15 Aug 2019 07:51:03 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id e15sm805595qtr.51.2019.08.15.07.51.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Aug 2019 07:51:02 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hyH5i-0005L9-BH; Thu, 15 Aug 2019 11:51:02 -0300 Date: Thu, 15 Aug 2019 11:51:02 -0300 From: Jason Gunthorpe To: Jan Kara Cc: John Hubbard , Ira Weiny , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , =?utf-8?B?SsOpcsO0bWU=?= Glisse , LKML , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [RFC PATCH 2/2] mm/gup: introduce vaddr_pin_pages_remote() Message-ID: <20190815145102.GH21596@ziepe.ca> References: <20190812234950.GA6455@iweiny-DESK2.sc.intel.com> <38d2ff2f-4a69-e8bd-8f7c-41f1dbd80fae@nvidia.com> <20190813210857.GB12695@iweiny-DESK2.sc.intel.com> <90e5cd11-fb34-6913-351b-a5cc6e24d85d@nvidia.com> <20190814234959.GA463@iweiny-DESK2.sc.intel.com> <2cbdf599-2226-99ae-b4d5-8909a0a1eadf@nvidia.com> <20190815132622.GG14313@quack2.suse.cz> <20190815133510.GA21302@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190815133510.GA21302@quack2.suse.cz> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Aug 15, 2019 at 03:35:10PM +0200, Jan Kara wrote: > > 3) ODP case - GUP references to pages serving as DMA buffers, MMU notifiers > > used to synchronize with page_mkclean() and munmap() => normal page > > references are fine. > > I want to add that I'd like to convert users in cases 1) and 2) from using > GUP to using differently named function. Users in case 3) can stay as they > are for now although ultimately I'd like to denote such use cases in a > special way as well... 3) users also want a special function and path, right now it is called hmm_range_fault() but perhaps it would be good to harmonize it more with the GUP infrastructure? I'm not quite sure what the best plan for that is yet. Jason