From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 784A2C3A59F for ; Sun, 18 Aug 2019 09:29:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D81B21773 for ; Sun, 18 Aug 2019 09:29:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b="rstR/tV5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726175AbfHRJ3I (ORCPT ); Sun, 18 Aug 2019 05:29:08 -0400 Received: from sonic317-22.consmr.mail.gq1.yahoo.com ([98.137.66.148]:40218 "EHLO sonic317-22.consmr.mail.gq1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbfHRJ3I (ORCPT ); Sun, 18 Aug 2019 05:29:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1566120547; bh=elNzjKtOd8tHsVMRzwJVP/2i4hqq6jHwCebjdt6foXA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=rstR/tV5mq2tGQnRWKksVEd7fTtZ6MYHGw4G3DzIxbKxuDi66go24Lkj+RdUh1INQ3mqogioAitvYF5OYwFWASXWFV8RyOb8gvYVKGS0VJAhNnLvHut8Qd/eiDKe+InBI4IBJOCL6UrGyWAzpbOCzup1K3NP/v/rWK0JRCLYK8KYVbFkeOYubBnDfDrYUFAIxuWs/2kRRrNDJVyfguRv+WkyLXgl2trngpNsRbfLtazlJAJikA7nzI8Sq8rlRJsaYUl1b4sLd7nuFpGzLCwUek+0234fKjjma16KpdjKBVzFLrEJhR/YqBC3xWPAhcQEUvMKCpCCdoUOe/+f/lk9CA== X-YMail-OSG: 67dmY8AVM1n76X4YJ_Wsb_3kQNM256dgFTpNJZS_44izD_3iUPAYd8QsVETZem5 MMFNmnKehg4a9oiqDbNtSG2ss6jL12h3ZrUYXqJj9oGWb2.JwlM2IvJonU8KVjv2HkRyFcIU3oO8 MSw2TfrhrB.2vuHiUzTAEqAQkTqJzpC3iHb.MXJOqe.zHBUpYz3jlrDdRZj0wP97xJm1Me6_fZIH r1whmR_ZARK_nNlUdVH1blUkHRP74JVXEYYrAUWA7bk3wgIMSrPfQ9mf0blZeWWEsw0US3_KjNa9 rDHJiPhps6WrviSV.VphpO6gqIagpp131eDTk0FFSezeDGIWPsQTe.5kqSdNgTdvkseQN6ES5Jt. dNSh4SAmIMtyyNQ8Rs7hJJHUIRk82ErgDCNO6LUdiPQWxqGkG0tdGHU1qdyptgRB1wp5shwqfwMm tKUgpGcQL6.O2pjqzP0ctoGWUOjf1L2a5psYJyR1HhAVLxxvEXM2xID05Fv2euByK88daRak.HjF VxusuvUUoJrSudbxh5Azlq2I1_lI9NqBcc50LQEGd_ea0OHfBz9c72Ut3iKWVSK4z4HEo0skdAJP R3DXJbq7xAlYEc8zIRpdshQFIa8uaFh6xI3ej3riFr3SwAOUayG8TjHsHoI1jqf80aJkUC55bgJO 2BwwrzrvyPHC6YKMKCgQkP63z8Mzha0R5zYsA4C2z.p6S4kjTip3WMaTBH5D2L1I1.bTKVNBhb9Y YdhDxFCIuYixDzE4WZog6T7C7P3PJaH4CnBtadWWHWr5GRE4UV_CMmCocDglv4w3UbUVORTW37P0 4xfEGGB7hocRFJPdmKYNLUtTdKh2jI6CaEqlp9bKFkYD2AX3lAXYJo7Q1CUq95OJ9kE3Pcv8O8tM Cutfs60iItiFgev6Sp1vEtJzeo4h7eTaNnPMCrik6LBaTmgxtOxFzc..jgMX5YPYBYOE_3u247Y. uMX8.W.EahwTYkqh4HDAPSYb7lehqS5C3n2Vg6ht5tU_v63I6r3SGY51Yl1bST3pnaj35cXIzlQz FhHDw6mEV.AqxjQC6gnBP9KK822l2V7728y67AmvXlVo4oPbM0.2zqomuqOIaOp2d0IsV_qc9lZ. zTqxG7qNgve6FtZpgI.38TCic8jI3Ud5Q6eI52lmTMpW2l7Ug_qKM.Js56ZWrRECx6qzyg_bZwqf j1IZXkcuQAf.C7BSWuUBnx83cAYXkad9xFbT_e7NSSfISOKL4Nf5JFLnCjVEDJLUXs..tfH92Tzu CoRl1S1djCKU6TrVudNK6kqQkxEMHZpYuUldf4A-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.gq1.yahoo.com with HTTP; Sun, 18 Aug 2019 09:29:07 +0000 Received: by smtp420.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID ca20b18070ed0178b8c3396d5cdfbdc7; Sun, 18 Aug 2019 09:29:04 +0000 (UTC) Date: Sun, 18 Aug 2019 17:28:43 +0800 From: Gao Xiang To: Richard Weinberger Cc: Greg Kroah-Hartman , Al Viro , linux-fsdevel , devel , linux-erofs , linux-kernel , Andrew Morton , Stephen Rothwell , tytso , Pavel Machek , David Sterba , Amir Goldstein , Christoph Hellwig , Darrick , Dave Chinner , Jaegeuk Kim , Jan Kara , torvalds , Chao Yu , Miao Xie , Li Guifu , Fang Wei , Gao Xiang Subject: Re: [PATCH] erofs: move erofs out of staging Message-ID: <20190818092839.GA18975@hsiangkao-HP-ZHAN-66-Pro-G1> References: <20190817082313.21040-1-hsiangkao@aol.com> <1746679415.68815.1566076790942.JavaMail.zimbra@nod.at> <20190817220706.GA11443@hsiangkao-HP-ZHAN-66-Pro-G1> <1163995781.68824.1566084358245.JavaMail.zimbra@nod.at> <20190817233843.GA16991@hsiangkao-HP-ZHAN-66-Pro-G1> <1405781266.69008.1566116210649.JavaMail.zimbra@nod.at> <20190818084521.GA17909@hsiangkao-HP-ZHAN-66-Pro-G1> <1133002215.69049.1566119033047.JavaMail.zimbra@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=gbk Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1133002215.69049.1566119033047.JavaMail.zimbra@nod.at> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, Aug 18, 2019 at 11:03:53AM +0200, Richard Weinberger wrote: > ----- Urspr??ngliche Mail ----- > > I agree with you, but what can we do now is trying our best to fuzz > > all the fields. > > > > So, what is your opinion about EROFS? > > All I'm saying is that you should not blindly trust the disk. I completely agree with you, and I'm teaching EROFS to make the little naughty boy more strong... (we already have many error handling code, but I think I will teach him more, yes.) > > Another thing that raises my attention is in superblock_read(): > memcpy(sbi->volume_name, layout->volume_name, > sizeof(layout->volume_name)); > > Where do you check whether ->volume_name has a NUL terminator? > Currently this field has no user, maybe will add a check upon usage. > But this kind of things makes me wonder. Yes, I think this is a good point. :) Since volume_name is not used currently, I will fix it when it use late. I will make a note here (or more straightforward, I will fix it to avoid potential bug now.) Thanks, Gao Xiang > > Thanks, > //richard