From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3095C3A589 for ; Sun, 18 Aug 2019 16:16:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D1282146E for ; Sun, 18 Aug 2019 16:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566145003; bh=NSSy4mA2IcwfuYQPcB9hX5r00sDDMr1GAhaImAFrjmk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xi9EoNu66zKIi9zc96/V1jXJvYyYbMtP1jWC/r3L2wfuUtYr103J8pOq8YnNdIciT yVDvOB1+50n4F9dwpEmFl9VDENlnuPzDvtp3G9pOromY6Bh8R4VycmvD1anUwNXVLN LdCTCu78xwtGQ1XxD8+A7h8S6jZ9rQVdzPBQT+jU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726256AbfHRQQm (ORCPT ); Sun, 18 Aug 2019 12:16:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:48316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbfHRQQl (ORCPT ); Sun, 18 Aug 2019 12:16:41 -0400 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31EFF20644; Sun, 18 Aug 2019 16:16:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566145000; bh=NSSy4mA2IcwfuYQPcB9hX5r00sDDMr1GAhaImAFrjmk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TJuDeqIz1AOUrfjI4tJ2s99hzAlFWk84d4zcmb/BVNJEFYVx2WKrptDAGwtmkk2TK LnxnxmgqgQCUC4un3j70hQ1g7AfuNzkiHyG12ZIyk04RrJz3+ahO8wpJ1G5gmacEA1 fl36zAQND7Sp3qSvk1n1LO8kcK1bjbBoAOftLsAg= Date: Sun, 18 Aug 2019 09:16:38 -0700 From: Eric Biggers To: Christoph Hellwig Cc: "Theodore Y. Ts'o" , Richard Weinberger , Greg Kroah-Hartman , Gao Xiang , Jan Kara , Chao Yu , Dave Chinner , David Sterba , Miao Xie , devel , Stephen Rothwell , Darrick , Amir Goldstein , linux-erofs , Al Viro , Jaegeuk Kim , linux-kernel , Li Guifu , Fang Wei , Pavel Machek , linux-fsdevel , Andrew Morton , torvalds Subject: Re: [PATCH] erofs: move erofs out of staging Message-ID: <20190818161638.GE1118@sol.localdomain> Mail-Followup-To: Christoph Hellwig , "Theodore Y. Ts'o" , Richard Weinberger , Greg Kroah-Hartman , Gao Xiang , Jan Kara , Chao Yu , Dave Chinner , David Sterba , Miao Xie , devel , Stephen Rothwell , Darrick , Amir Goldstein , linux-erofs , Al Viro , Jaegeuk Kim , linux-kernel , Li Guifu , Fang Wei , Pavel Machek , linux-fsdevel , Andrew Morton , torvalds References: <20190817220706.GA11443@hsiangkao-HP-ZHAN-66-Pro-G1> <1163995781.68824.1566084358245.JavaMail.zimbra@nod.at> <20190817233843.GA16991@hsiangkao-HP-ZHAN-66-Pro-G1> <1405781266.69008.1566116210649.JavaMail.zimbra@nod.at> <20190818084521.GA17909@hsiangkao-HP-ZHAN-66-Pro-G1> <1133002215.69049.1566119033047.JavaMail.zimbra@nod.at> <20190818090949.GA30276@kroah.com> <790210571.69061.1566120073465.JavaMail.zimbra@nod.at> <20190818151154.GA32157@mit.edu> <20190818155812.GB13230@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190818155812.GB13230@infradead.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, Aug 18, 2019 at 08:58:12AM -0700, Christoph Hellwig wrote: > On Sun, Aug 18, 2019 at 11:11:54AM -0400, Theodore Y. Ts'o wrote: > > Note that of the mainstream file systems, ext4 and xfs don't guarantee > > that it's safe to blindly take maliciously provided file systems, such > > as those provided by a untrusted container, and mount it on a file > > system without problems. As I recall, one of the XFS developers > > described file system fuzzing reports as a denial of service attack on > > the developers. > > I think this greatly misrepresents the general attitute of the XFS > developers. We take sanity checks for the modern v5 on disk format > very series, and put a lot of effort into handling corrupted file > systems as good as possible, although there are of course no guaranteeѕ. > > The quote that you've taken out of context is for the legacy v4 format > that has no checksums and other integrity features. Ted's observation was about maliciously-crafted filesystems, though, so integrity-only features such as metadata checksums are irrelevant. Also the filesystem version is irrelevant; anything accepted by the kernel code (even if it's legacy/deprecated) is open attack surface. I personally consider it *mandatory* that we deal with this stuff. But I can understand that we don't do a good job at it, so we shouldn't hold a new filesystem to an unfairly high standard relative to other filesystems... - Eric