From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C861C3A589 for ; Sun, 18 Aug 2019 20:14:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 107612184D for ; Sun, 18 Aug 2019 20:14:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b="uOmq2/c9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727068AbfHRUOb (ORCPT ); Sun, 18 Aug 2019 16:14:31 -0400 Received: from sonic309-25.consmr.mail.ir2.yahoo.com ([77.238.179.83]:36912 "EHLO sonic309-25.consmr.mail.ir2.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbfHRUOa (ORCPT ); Sun, 18 Aug 2019 16:14:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1566159267; bh=AFQH++1o8RqOOUXXy/R8iJf31JxjU49TDMxPTBy6oBE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=uOmq2/c9/k0JwKIqGm2gloVmxlgPrw2KVO1WcL8YA9pc3GEMnMNjZ5Q15OZy+TMCWWHaFxCnxEVzIUfxT5Cr02/I8HuAsI2TxsBpf65988Mjop+COYO+FKOz6hrtR1w6dBJl6Nss5c/Ko5PQDnThLexu9ClvIIYUtp3ZWOxhorx9fwWcWx1QOhLdpa6ffZqKWEcRMq+ZjdPaBq5oLxdEOimBGXo0Op1Avh9F4/AY6pz5pMAmLiwxwoOavMJ05omgMClBZyg+3dxD7ZFhHjPVjBOk4vCMRBBHWzexu0ygQVpuKPxFuw0BWQfXnnOfvvbh/YMS0ebtPNCQh5L/9tqoIA== X-YMail-OSG: .b8Nt5gVM1kx.R8Yaz9Pl9V_wC0zOVwY1sfzUw9vCTmDCP8Lq65rlFvtdnA6ZQN nZ9ikC1xCKK9cLbHJH8OSsBZs0isv.JvCfx8D2KN8cN.tO_WthRJ8ujtJ_8T9jwjjDHjhDQ7_fm2 A6QqVI10xHfzzBZMl3qzpYRdfR.CYLsGWKcTZ7Iw8EUybB1ICE9Qm13F5H76scvUNXVlT72MX62d L.FH6bN6kj3uymZ7Q_oJTbLuT8i5qGD.e1bJzIEjhfvsVQ9ePWXvUjytRxIxLxvukmHDY6Jmm_ZR qstmSvMe6PZcrkhwhr562chlFiE7sPmYfuKNpJJkGhmq6aGYEEZr9JERIeA4NrxxwjngpeNx3Djf QvTBfKuhah.n0eR3J6maHtC2aiMqzomfBixMiJ15Bsyg8dPG72GcTNcPUAUY6kpkbCIvnwH90NUs i_7CiFf48U2xX3z4lmOD6K51xswQWDCBuKu2qRaosL9MYKZOy.Uo2dW7vdVaj8fIA1KyDuR3hoXu avPtCIOHr.AjaalOMyMtiU3S8dmFd.oO1L2NJu.8_fcNn2Wq4YSp45FgSW2bUbWBeqWu6U3g3RDX cewBlaITj9UQkHZe.EbCg_skUI3ca_dcD2TTzzoENlQuqcZCtKgfJ4B34REuUDRvoIeF7xY99Bab FNU_KMQg72Bk7Z33heLyrwTek6WbWo.wR3511tLpPUVEEoAEU4v7meG1iCOWMcLS8_iQICvcZE9f gJ8_0jDSK_KE.6yzygDgq9LZY4rTa1bgC6InA0uP_3OtZSB0wVTxjGMv.aqM9WJuZi1GKLKHDmXw oEL4gvIOpEfAnfR5o7tbqctLUzcv.XEp8ItWDjT260DKw5FfyEH.zk_KW_F7.vpi3QvNKTXdV2rc Vjnyk3x4I4lKpLKqUNYu8HaMmwNSukzt5O4Ya0pPidxdO2Ke6DShFcbHdPkNF9_ipK.siCzTXgKw JhxIgP21nFlhpKerZPQzESGLAA0c4Mvrjw8deEZ1sazRJHzFlqZdLjRE_41xjChF_B9sy0c3miGW pxKMWRxjAPApVb2ls8pAqHAgfsHBsTRfFE7GiqwEuXZYF2CowYGDb4_h3MZ_kfLAZDEnf7GbEQxS DwjsMFETT0O4js80_PWTxc_74ijPYa7FQfifCHgNgNPZqOMSJZa9Nm_Fwe6wtqHy2lmvJu4ndA5B Ry5.sYUTzj_g0toV79UwQYL.3M.PlWIbc35M7J6XTHe1fPXA9rNX8Ulh8s7vDIXZDLZtCkFQrVDm pRzpWGjxKvMuJW5nweQAINF980DgF4QCq8vPKer9leKeqn0Ob Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ir2.yahoo.com with HTTP; Sun, 18 Aug 2019 20:14:27 +0000 Received: by smtp408.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 58ed0af1afde63f1f88d3ff16ad71068; Sun, 18 Aug 2019 20:14:24 +0000 (UTC) Date: Mon, 19 Aug 2019 04:14:11 +0800 From: Gao Xiang To: Christoph Hellwig , "Theodore Y. Ts'o" , Eric Biggers , Richard Weinberger Cc: Greg Kroah-Hartman , Jan Kara , Chao Yu , Dave Chinner , David Sterba , Miao Xie , devel , Stephen Rothwell , Darrick , Amir Goldstein , linux-erofs , Al Viro , Jaegeuk Kim , linux-kernel , Li Guifu , Fang Wei , Pavel Machek , linux-fsdevel , Andrew Morton , torvalds Subject: Re: [PATCH] erofs: move erofs out of staging Message-ID: <20190818201405.GA27398@hsiangkao-HP-ZHAN-66-Pro-G1> References: <1133002215.69049.1566119033047.JavaMail.zimbra@nod.at> <20190818090949.GA30276@kroah.com> <790210571.69061.1566120073465.JavaMail.zimbra@nod.at> <20190818151154.GA32157@mit.edu> <20190818155812.GB13230@infradead.org> <20190818161638.GE1118@sol.localdomain> <20190818162201.GA16269@infradead.org> <20190818172938.GA14413@sol.localdomain> <20190818174702.GA17633@infradead.org> <20190818181654.GA1617@hsiangkao-HP-ZHAN-66-Pro-G1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190818181654.GA1617@hsiangkao-HP-ZHAN-66-Pro-G1> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi all, On Mon, Aug 19, 2019 at 02:16:55AM +0800, Gao Xiang wrote: > Hi Hch, > > On Sun, Aug 18, 2019 at 10:47:02AM -0700, Christoph Hellwig wrote: > > On Sun, Aug 18, 2019 at 10:29:38AM -0700, Eric Biggers wrote: > > > Not sure what you're even disagreeing with, as I *do* expect new filesystems to > > > be held to a high standard, and to be written with the assumption that the > > > on-disk data may be corrupted or malicious. We just can't expect the bar to be > > > so high (e.g. no bugs) that it's never been attained by *any* filesystem even > > > after years/decades of active development. If the developers were careful, the > > > code generally looks robust, and they are willing to address such bugs as they > > > are found, realistically that's as good as we can expect to get... > > > > Well, the impression I got from Richards quick look and the reply to it is > > that there is very little attempt to validate the ondisk data structure > > and there is absolutely no priority to do so. Which is very different > > from there is a bug or two here and there. > > As my second reply to Richard, I didn't fuzz all the on-disk fields for EROFS. > and as my reply to Richard / Greg, current EROFS is used on the top of dm-verity. > > I cannot say how well EROFS will be performed on malformed images (and you can > also find the bug richard pointed out is a miswritten break->continue by myself). > > I posted the upstream EROFS post on July 4, 2019 and a month and a half later, > no one can tell me (yes, thanks for kind people reply me about their suggestion) > what we should do next (you can see these emails, I sent many times) to meet > the minimal upstream requirements and rare people can even dip into my code. > > That is all I want to say. I will work on autofuzz these days, and I want to > know how to meet your requirements on this (you can tell us your standard, > how well should we do). > > OK, you don't reply to my post once, I have no idea how to get your first reply. I have made a simple fuzzer to inject messy in inode metadata, dir data, compressed indexes and super block, https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/commit/?h=experimental-fuzzer I am testing with some given dirs and the following script. Does it look reasonable? # !/bin/bash mkdir -p mntdir for ((i=0; i<1000; ++i)); do mkfs/mkfs.erofs -F$i testdir_fsl.fuzz.img testdir_fsl > /dev/null 2>&1 umount mntdir mount -t erofs -o loop testdir_fsl.fuzz.img mntdir for j in `find mntdir -type f`; do md5sum $j > /dev/null done done Thanks, Gao Xiang > > Thanks, > Gao Xiang >