From: kbuild test robot <lkp@intel.com>
To: Gao Xiang <hsiangkao@aol.com>
Cc: kbuild-all@01.org, Chao Yu <yuchao0@huawei.com>,
Richard Weinberger <richard@nod.at>,
Matthew Wilcox <willy@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org,
linux-erofs@lists.ozlabs.org, Chao Yu <chao@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Fang Wei <fangwei1@huawei.com>,
Miao Xie <miaoxie@huawei.com>
Subject: Re: [PATCH] staging: erofs: fix an error handling in erofs_readdir()
Date: Sun, 18 Aug 2019 21:17:52 +0800 [thread overview]
Message-ID: <201908182116.RRufKUpl%lkp@intel.com> (raw)
In-Reply-To: <20190818031855.9723-1-hsiangkao@aol.com>
[-- Attachment #1: Type: text/plain, Size: 3569 bytes --]
Hi Gao,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc4 next-20190816]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Gao-Xiang/staging-erofs-fix-an-error-handling-in-erofs_readdir/20190818-191344
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/staging/erofs/dir.c: In function 'erofs_readdir':
>> drivers/staging/erofs/dir.c:110:11: error: 'EFSCORRUPTED' undeclared (first use in this function); did you mean 'FS_NRSUPER'?
err = -EFSCORRUPTED;
^~~~~~~~~~~~
FS_NRSUPER
drivers/staging/erofs/dir.c:110:11: note: each undeclared identifier is reported only once for each function it appears in
vim +110 drivers/staging/erofs/dir.c
85
86 static int erofs_readdir(struct file *f, struct dir_context *ctx)
87 {
88 struct inode *dir = file_inode(f);
89 struct address_space *mapping = dir->i_mapping;
90 const size_t dirsize = i_size_read(dir);
91 unsigned int i = ctx->pos / EROFS_BLKSIZ;
92 unsigned int ofs = ctx->pos % EROFS_BLKSIZ;
93 int err = 0;
94 bool initial = true;
95
96 while (ctx->pos < dirsize) {
97 struct page *dentry_page;
98 struct erofs_dirent *de;
99 unsigned int nameoff, maxsize;
100
101 dentry_page = read_mapping_page(mapping, i, NULL);
102 if (dentry_page == ERR_PTR(-ENOMEM)) {
103 errln("no memory to readdir of logical block %u of nid %llu",
104 i, EROFS_V(dir)->nid);
105 err = -ENOMEM;
106 break;
107 } else if (IS_ERR(dentry_page)) {
108 errln("fail to readdir of logical block %u of nid %llu",
109 i, EROFS_V(dir)->nid);
> 110 err = -EFSCORRUPTED;
111 break;
112 }
113
114 de = (struct erofs_dirent *)kmap(dentry_page);
115
116 nameoff = le16_to_cpu(de->nameoff);
117
118 if (unlikely(nameoff < sizeof(struct erofs_dirent) ||
119 nameoff >= PAGE_SIZE)) {
120 errln("%s, invalid de[0].nameoff %u",
121 __func__, nameoff);
122
123 err = -EIO;
124 goto skip_this;
125 }
126
127 maxsize = min_t(unsigned int,
128 dirsize - ctx->pos + ofs, PAGE_SIZE);
129
130 /* search dirents at the arbitrary position */
131 if (unlikely(initial)) {
132 initial = false;
133
134 ofs = roundup(ofs, sizeof(struct erofs_dirent));
135 if (unlikely(ofs >= nameoff))
136 goto skip_this;
137 }
138
139 err = erofs_fill_dentries(ctx, de, &ofs, nameoff, maxsize);
140 skip_this:
141 kunmap(dentry_page);
142
143 put_page(dentry_page);
144
145 ctx->pos = blknr_to_addr(i) + ofs;
146
147 if (unlikely(err))
148 break;
149 ++i;
150 ofs = 0;
151 }
152 return err < 0 ? err : 0;
153 }
154
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66441 bytes --]
next prev parent reply other threads:[~2019-08-18 13:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 1:48 [PATCH] staging: erofs: fix an error handling in erofs_readdir() Gao Xiang
2019-08-18 1:56 ` [PATCH v2] " Gao Xiang
2019-08-18 2:20 ` Matthew Wilcox
2019-08-18 2:32 ` Gao Xiang
2019-08-18 2:53 ` Matthew Wilcox
2019-08-18 3:01 ` Gao Xiang
2019-08-18 3:18 ` [PATCH] " Gao Xiang
2019-08-18 12:07 ` kbuild test robot
2019-08-18 13:17 ` kbuild test robot [this message]
2019-08-18 13:25 ` Gao Xiang
2019-08-20 6:50 ` Philip Li
2019-08-20 6:50 ` Gao Xiang
2019-08-20 6:58 ` Li, Philip
2019-08-20 7:16 ` Gao Xiang
2019-08-18 3:21 ` [PATCH v3 RESEND] " Gao Xiang
2019-08-18 8:33 ` Richard Weinberger
2019-08-18 9:10 ` Gao Xiang
2019-08-18 9:18 ` [PATCH v3 RESEND] staging: erofs: fix an error handling in erofs_readdir()y Gao Xiang
2019-08-18 12:29 ` [PATCH v3 RESEND] staging: erofs: fix an error handling in erofs_readdir() Chao Yu
2019-08-18 12:33 ` Matthew Wilcox
2019-08-18 12:38 ` Gao Xiang
2019-08-18 12:54 ` [PATCH v4] " Gao Xiang
2019-08-18 10:39 ` [PATCH v2] " Chao Yu
2019-08-18 10:52 ` Gao Xiang
2019-08-18 12:28 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201908182116.RRufKUpl%lkp@intel.com \
--to=lkp@intel.com \
--cc=chao@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=fangwei1@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsiangkao@aol.com \
--cc=kbuild-all@01.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).