archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <>
To: Sergey Senozhatsky <>
Cc: Jani Nikula <>,
	Joonas Lahtinen <>,
	Rodrigo Vivi <>,
	Chris Wilson <>,
	Alexander Viro <>,
	David Howells <>,
	Christoph Hellwig <>,,,,,
	Sergey Senozhatsky <>
Subject: Re: [PATCHv2 2/2] i915: do not leak module ref counter
Date: Tue, 20 Aug 2019 07:56:23 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Aug 20, 2019 at 12:13:59PM +0900, Sergey Senozhatsky wrote:
> Always put_filesystem() in i915_gemfs_init().
> Signed-off-by: Sergey Senozhatsky <>
> ---
>  - v2: rebased (i915 does not remount gemfs anymore)

Which means it real doesn't need its mount anyore, and thus can use
plain old shmem_file_setup and doesn't need to mess with file system
types at all.

Assuming we find a legitimate rason for why a driver should be able
to create a kernel mount or a file system type where it doesn't have
access to the struct file_system_type an API that mount by file system
name and thus hides the get_fs_type and put_filesystem would be a much
better API than adding this random export.

      reply	other threads:[~2019-08-20  5:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20  3:13 [PATCHv2 1/2] fs: export put_filesystem() Sergey Senozhatsky
2019-08-20  3:13 ` [PATCHv2 2/2] i915: do not leak module ref counter Sergey Senozhatsky
2019-08-20  5:56   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCHv2 2/2] i915: do not leak module ref counter' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).