From: kbuild test robot <lkp@intel.com>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: kbuild-all@01.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
Dave Chinner <david@fromorbit.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Matias Bjorling <matias.bjorling@wdc.com>
Subject: Re: [PATCH V2] fs: New zonefs file system
Date: Wed, 21 Aug 2019 01:42:31 +0800 [thread overview]
Message-ID: <201908210118.6DOPwuQp%lkp@intel.com> (raw)
In-Reply-To: <20190820081249.27353-1-damien.lemoal@wdc.com>
[-- Attachment #1: Type: text/plain, Size: 5335 bytes --]
Hi Damien,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc5 next-20190820]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Damien-Le-Moal/fs-New-zonefs-file-system/20190820-232131
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
>> fs/zonefs/super.c:83:37: warning: 'struct iomap_writepage_ctx' declared inside parameter list will not be visible outside of this definition or declaration
static int zonefs_map_blocks(struct iomap_writepage_ctx *wpc,
^~~~~~~~~~~~~~~~~~~
fs/zonefs/super.c: In function 'zonefs_map_blocks':
>> fs/zonefs/super.c:86:19: error: dereferencing pointer to incomplete type 'struct iomap_writepage_ctx'
if (offset >= wpc->iomap.offset &&
^~
fs/zonefs/super.c: At top level:
>> fs/zonefs/super.c:95:21: error: variable 'zonefs_writeback_ops' has initializer but incomplete type
static const struct iomap_writeback_ops zonefs_writeback_ops = {
^~~~~~~~~~~~~~~~~~~
>> fs/zonefs/super.c:96:3: error: 'const struct iomap_writeback_ops' has no member named 'map_blocks'
.map_blocks = zonefs_map_blocks,
^~~~~~~~~~
>> fs/zonefs/super.c:96:17: warning: excess elements in struct initializer
.map_blocks = zonefs_map_blocks,
^~~~~~~~~~~~~~~~~
fs/zonefs/super.c:96:17: note: (near initialization for 'zonefs_writeback_ops')
fs/zonefs/super.c: In function 'zonefs_writepage':
>> fs/zonefs/super.c:101:9: error: variable 'wpc' has initializer but incomplete type
struct iomap_writepage_ctx wpc = { };
^~~~~~~~~~~~~~~~~~~
>> fs/zonefs/super.c:101:29: error: storage size of 'wpc' isn't known
struct iomap_writepage_ctx wpc = { };
^~~
>> fs/zonefs/super.c:103:9: error: implicit declaration of function 'iomap_writepage'; did you mean 'iomap_readpage'? [-Werror=implicit-function-declaration]
return iomap_writepage(page, wbc, &wpc, &zonefs_writeback_ops);
^~~~~~~~~~~~~~~
iomap_readpage
fs/zonefs/super.c:101:29: warning: unused variable 'wpc' [-Wunused-variable]
struct iomap_writepage_ctx wpc = { };
^~~
fs/zonefs/super.c: In function 'zonefs_writepages':
fs/zonefs/super.c:109:9: error: variable 'wpc' has initializer but incomplete type
struct iomap_writepage_ctx wpc = { };
^~~~~~~~~~~~~~~~~~~
fs/zonefs/super.c:109:29: error: storage size of 'wpc' isn't known
struct iomap_writepage_ctx wpc = { };
^~~
>> fs/zonefs/super.c:111:9: error: implicit declaration of function 'iomap_writepages'; did you mean 'do_writepages'? [-Werror=implicit-function-declaration]
return iomap_writepages(mapping, wbc, &wpc, &zonefs_writeback_ops);
^~~~~~~~~~~~~~~~
do_writepages
fs/zonefs/super.c:109:29: warning: unused variable 'wpc' [-Wunused-variable]
struct iomap_writepage_ctx wpc = { };
^~~
fs/zonefs/super.c: At top level:
>> fs/zonefs/super.c:95:41: error: storage size of 'zonefs_writeback_ops' isn't known
static const struct iomap_writeback_ops zonefs_writeback_ops = {
^~~~~~~~~~~~~~~~~~~~
fs/zonefs/super.c: In function 'zonefs_writepages':
>> fs/zonefs/super.c:112:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
fs/zonefs/super.c: In function 'zonefs_writepage':
fs/zonefs/super.c:104:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
cc1: some warnings being treated as errors
vim +86 fs/zonefs/super.c
82
> 83 static int zonefs_map_blocks(struct iomap_writepage_ctx *wpc,
84 struct inode *inode, loff_t offset)
85 {
> 86 if (offset >= wpc->iomap.offset &&
87 offset < wpc->iomap.offset + wpc->iomap.length)
88 return 0;
89
90 memset(&wpc->iomap, 0, sizeof(wpc->iomap));
91 return zonefs_iomap_begin(inode, offset, zonefs_file_max_size(inode),
92 0, &wpc->iomap);
93 }
94
> 95 static const struct iomap_writeback_ops zonefs_writeback_ops = {
> 96 .map_blocks = zonefs_map_blocks,
97 };
98
99 static int zonefs_writepage(struct page *page, struct writeback_control *wbc)
100 {
> 101 struct iomap_writepage_ctx wpc = { };
102
> 103 return iomap_writepage(page, wbc, &wpc, &zonefs_writeback_ops);
104 }
105
106 static int zonefs_writepages(struct address_space *mapping,
107 struct writeback_control *wbc)
108 {
> 109 struct iomap_writepage_ctx wpc = { };
110
> 111 return iomap_writepages(mapping, wbc, &wpc, &zonefs_writeback_ops);
> 112 }
113
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69518 bytes --]
next prev parent reply other threads:[~2019-08-20 17:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 8:12 [PATCH V2] fs: New zonefs file system Damien Le Moal
2019-08-20 15:26 ` Darrick J. Wong
2019-08-21 1:05 ` Damien Le Moal
2019-08-21 1:43 ` Darrick J. Wong
2019-08-21 2:24 ` Damien Le Moal
2019-08-20 17:42 ` kbuild test robot [this message]
2019-08-22 22:43 ` Luis Chamberlain
2019-08-26 4:39 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201908210118.6DOPwuQp%lkp@intel.com \
--to=lkp@intel.com \
--cc=damien.lemoal@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=kbuild-all@01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=matias.bjorling@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).