From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E8B9C3A5A2 for ; Fri, 23 Aug 2019 04:29:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F97B23429 for ; Fri, 23 Aug 2019 04:29:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391653AbfHWE3D (ORCPT ); Fri, 23 Aug 2019 00:29:03 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:58676 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726283AbfHWE3C (ORCPT ); Fri, 23 Aug 2019 00:29:02 -0400 Received: from gondolin.me.apana.org.au ([192.168.0.6] helo=gondolin.hengli.com.au) by fornost.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1i11At-0006rg-Aj; Fri, 23 Aug 2019 14:27:43 +1000 Received: from herbert by gondolin.hengli.com.au with local (Exim 4.80) (envelope-from ) id 1i11AE-0004RC-MF; Fri, 23 Aug 2019 14:27:02 +1000 Date: Fri, 23 Aug 2019 14:27:02 +1000 From: Herbert Xu To: "boojin.kim" Cc: "'David S. Miller'" , 'Eric Biggers' , "'Theodore Y. Ts'o'" , 'Chao Yu' , 'Jaegeuk Kim' , 'Andreas Dilger' , dm-devel@redhat.com, 'Mike Snitzer' , 'Alasdair Kergon' , 'Jens Axboe' , 'Krzysztof Kozlowski' , 'Kukjin Kim' , 'Jaehoon Chung' , 'Ulf Hansson' , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-mmc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 6/9] dm crypt: support diskcipher Message-ID: <20190823042702.GA17034@gondor.apana.org.au> References: <017901d5596a$1df3a590$59daf0b0$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <017901d5596a$1df3a590$59daf0b0$@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Aug 23, 2019 at 01:20:37PM +0900, boojin.kim wrote: > > If yes, I think the following API needs to be added to skcipher: > - _set(): BIO submitter (dm-crypt, f2fs, ext4) sets cipher to BIO. > - _mergeable(): Block layer checks if two BIOs have the same cipher. > - _get(): Storage driver gets cipher from BIO. > - _set_crypt(): Storage driver gets crypto information from cipher and > writes it on the descriptor of Storage controller. > Is it acceptable to skcipher ? No. If you're after total offload then the crypto API is not for you. What we can support is the offloading of encryption/decryption over many sectors. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt