From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: "boojin.kim" <boojin.kim@samsung.com>
Cc: "'Satya Tangirala'" <satyat@google.com>,
"'Herbert Xu'" <herbert@gondor.apana.org.au>,
"'David S. Miller'" <davem@davemloft.net>,
"'Eric Biggers'" <ebiggers@kernel.org>,
"'Chao Yu'" <chao@kernel.org>,
"'Jaegeuk Kim'" <jaegeuk@kernel.org>,
"'Andreas Dilger'" <adilger.kernel@dilger.ca>,
dm-devel@redhat.com, "'Mike Snitzer'" <snitzer@redhat.com>,
"'Alasdair Kergon'" <agk@redhat.com>,
"'Jens Axboe'" <axboe@kernel.dk>,
"'Krzysztof Kozlowski'" <krzk@kernel.org>,
"'Kukjin Kim'" <kgene@kernel.org>,
"'Jaehoon Chung'" <jh80.chung@samsung.com>,
"'Ulf Hansson'" <ulf.hansson@linaro.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fscrypt@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-block@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-arm-kernel@lists.infradead.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/9] block: support diskcipher
Date: Tue, 27 Aug 2019 12:40:12 -0400 [thread overview]
Message-ID: <20190827164012.GN28066@mit.edu> (raw)
In-Reply-To: <03b201d55cb2$1d4d31b0$57e79510$@samsung.com>
On Tue, Aug 27, 2019 at 05:33:33PM +0900, boojin.kim wrote:
>
> Dear Satya.
> Keyslot manager is a good solution for ICE. And probably no issue for FMP.
> But, I think it's complicated for FMP because FMP doesn't need
> any keyslot control.
Hi Boojin,
I think the important thing to realize here is that there are a large
number of hardware devices for which the keyslot manager *is* needed.
And from the upstream kernel's perspective, supporting two different
schemes for supporting the inline encryption feature is more
complexity than just supporting one which is general enough to support
a wider variety of hardware devices.
If you want somethig which is only good for the hardware platform you
are charged to support, that's fine if it's only going to be in a
Samsung-specific kernel. But if your goal is to get something that
works upstream, especially if it requires changes in core layers of
the kernel, it's important that it's general enough to support most,
if not all, if the hardware devices in the industry.
Regards,
- Ted
next prev parent reply other threads:[~2019-08-27 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190827083334epcas2p115d479190b9a72c886f66569add78203@epcas2p1.samsung.com>
2019-08-27 8:33 ` [PATCH 5/9] block: support diskcipher boojin.kim
2019-08-27 16:40 ` Theodore Y. Ts'o [this message]
[not found] <CGME20190828022055epcas2p25525077d0a5a3fa5a2027bac06a10bc1@epcas2p2.samsung.com>
2019-08-28 2:20 ` boojin.kim
[not found] <CGME20190822005438epcas2p337aba06b328cdcdd1549395f0bbcfdbc@epcas2p3.samsung.com>
2019-08-22 0:54 ` boojin.kim
[not found] <CGME20190821064226epcas2p2835b8a9084988b79107e54abfc5e7dab@epcas2p2.samsung.com>
2019-08-21 6:42 ` boojin.kim
2019-08-21 12:09 ` Jens Axboe
2019-08-23 2:35 ` Satya Tangirala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827164012.GN28066@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=boojin.kim@samsung.com \
--cc=chao@kernel.org \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jaegeuk@kernel.org \
--cc=jh80.chung@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=satyat@google.com \
--cc=snitzer@redhat.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).