From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE56C3A5A6 for ; Wed, 28 Aug 2019 12:28:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BC2220856 for ; Wed, 28 Aug 2019 12:28:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726395AbfH1M1z (ORCPT ); Wed, 28 Aug 2019 08:27:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35084 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726391AbfH1M1z (ORCPT ); Wed, 28 Aug 2019 08:27:55 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 773003082D9E; Wed, 28 Aug 2019 12:27:55 +0000 (UTC) Received: from horse.redhat.com (unknown [10.18.25.158]) by smtp.corp.redhat.com (Postfix) with ESMTP id D55E05D9C9; Wed, 28 Aug 2019 12:27:49 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 307372206F5; Wed, 28 Aug 2019 08:27:49 -0400 (EDT) Date: Wed, 28 Aug 2019 08:27:49 -0400 From: Vivek Goyal To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, virtio-fs@redhat.com, Stefan Hajnoczi , "Dr. David Alan Gilbert" , Miklos Szeredi Subject: Re: [PATCH 02/13] fuse: Use default_file_splice_read for direct IO Message-ID: <20190828122749.GA912@redhat.com> References: <20190821173742.24574-1-vgoyal@redhat.com> <20190821173742.24574-3-vgoyal@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 28 Aug 2019 12:27:55 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Aug 28, 2019 at 09:45:28AM +0200, Miklos Szeredi wrote: > On Wed, Aug 21, 2019 at 7:38 PM Vivek Goyal wrote: > > > > From: Miklos Szeredi > > Nice patch, except I have no idea why I did this. Splice with > FOPEN_DIRECT_IO seems to work fine without it. I don't know either. I took it because it was there in one of the branches you were doing development on. > > Anyway, I'll just drop this, unless someone has an idea why it is > actually needed. Sure, drop this patch. If need be, we can dig it up later. Thanks Vivek