From: Christoph Hellwig <hch@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Christoph Hellwig" <hch@infradead.org>,
devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org,
"Sasha Levin" <alexander.levin@microsoft.com>,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
linux-kernel@vger.kernel.org,
"OGAWA Hirofumi" <hirofumi@mail.parknet.co.jp>
Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to staging
Date: Thu, 29 Aug 2019 02:41:36 -0700 [thread overview]
Message-ID: <20190829094136.GA28643@infradead.org> (raw)
In-Reply-To: <20190829063955.GA30193@kroah.com>
On Thu, Aug 29, 2019 at 08:39:55AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Aug 28, 2019 at 11:23:40PM -0700, Christoph Hellwig wrote:
> > Can we please just review the damn thing and get it into the proper
> > tree? That whole concept of staging file systems just has been one
> > fricking disaster, including Greg just moving not fully reviewed ones
> > over like erofs just because he feels like it. I'm getting sick and
> > tired of this scheme.
>
> For this filesystem, it's going to be a _lot_ of work before that can
> happen, and I'd really like to have lots of people help out with it
> instead of it living in random github trees for long periods of time.
Did you actually look at the thing instead of blindly applying some
pile of crap?
It basically is a reimplementation of fs/fat/ not up to kernel standards
with a few indirections thrown in to also support exfat. So no amount
of work on this codebase is really going to bring us forward. Instead
someone how can spend a couple days on this and actually has file
systems to test it just needs to bring the low-level format bits over
to our well tested fs/fat codebase instead of duplicating it.
next prev parent reply other threads:[~2019-08-29 9:41 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190828160817.6250-1-gregkh@linuxfoundation.org>
2019-08-28 17:00 ` [PATCH] staging: exfat: add exfat filesystem code to staging Greg Kroah-Hartman
2019-08-29 6:23 ` Christoph Hellwig
2019-08-29 6:39 ` Greg Kroah-Hartman
2019-08-29 9:41 ` Christoph Hellwig [this message]
2019-08-29 9:50 ` Greg Kroah-Hartman
2019-08-29 10:37 ` Christoph Hellwig
2019-08-29 11:04 ` Gao Xiang
2019-08-29 11:18 ` Greg Kroah-Hartman
2019-08-29 11:18 ` Greg Kroah-Hartman
2019-08-29 15:11 ` Dan Carpenter
2019-08-29 15:27 ` Gao Xiang
2019-08-29 15:43 ` Dan Carpenter
2019-08-29 15:51 ` Gao Xiang
2019-08-29 16:04 ` Gao Xiang
2019-08-30 8:34 ` Dan Carpenter
2019-08-30 8:43 ` Gao Xiang
2019-08-30 11:26 ` Dan Carpenter
2019-08-30 12:04 ` Gao Xiang
2019-08-29 16:44 ` Gao Xiang
2019-08-29 16:59 ` Joe Perches
2019-08-29 17:02 ` Gao Xiang
2019-08-30 2:06 ` Chao Yu
2019-08-30 6:38 ` Gao Xiang
2019-08-30 12:00 ` Checking usage of likeliness annotations Markus Elfring
2019-08-30 11:51 ` [PATCH] staging: exfat: add exfat filesystem code to staging David Sterba
2019-08-31 3:50 ` Chao Yu
2019-08-30 15:36 ` Christoph Hellwig
2019-08-30 21:54 ` Dave Chinner
2019-08-31 10:31 ` Valdis Klētnieks
2019-09-01 0:04 ` Dave Chinner
2019-08-29 7:01 ` Gao Xiang
2019-08-29 8:24 ` Gao Xiang
2019-08-29 9:51 ` Christoph Hellwig
2019-08-29 12:14 ` Pali Rohár
2019-08-29 12:34 ` Valdis Klētnieks
2019-08-29 12:46 ` Pali Rohár
2019-08-29 14:08 ` Markus Elfring
2019-08-29 15:44 ` Markus Elfring
2019-08-29 20:56 ` Pali Rohár
2019-08-29 23:18 ` Valdis Klētnieks
2019-08-29 23:35 ` Sasha Levin
2019-08-30 7:56 ` Pali Rohár
2019-10-16 14:03 ` Pali Rohár
2019-10-16 14:31 ` Sasha Levin
2019-10-16 16:03 ` Pali Rohár
2019-10-16 16:20 ` Sasha Levin
2019-10-16 16:22 ` Greg Kroah-Hartman
2019-10-16 16:32 ` Pali Rohár
2019-10-16 16:50 ` Greg Kroah-Hartman
2019-10-16 20:33 ` Sasha Levin
2019-10-16 21:53 ` Valdis Klētnieks
2019-10-17 7:53 ` Pali Rohár
2019-10-17 7:50 ` Pali Rohár
2020-02-13 0:06 ` Pali Rohár
2020-02-13 21:18 ` Sasha Levin
2020-02-14 22:16 ` Valdis Klētnieks
2020-02-14 22:43 ` Pali Rohár
2020-02-14 23:25 ` Valdis Klētnieks
2020-04-21 21:30 ` exfat upcase table for code points above U+FFFF (Was: Re: [PATCH] staging: exfat: add exfat filesystem code to staging) Pali Rohár
2020-04-27 15:49 ` Sasha Levin
2020-04-28 7:46 ` Pali Rohár
2019-10-16 16:05 ` [PATCH] staging: exfat: add exfat filesystem code to staging Valdis Klētnieks
2019-08-30 8:03 ` Pali Rohár
2019-08-30 15:40 ` Christoph Hellwig
2019-08-30 15:43 ` Pali Rohár
2019-09-14 13:39 ` [PATCH] staging: exfat: add exfat filesystem code to Park Ju Hyung
2019-09-15 13:54 ` Greg KH
2019-09-15 16:11 ` Ju Hyung Park
[not found] ` <20190918195920.25210-1-qkrwngud825@gmail.com>
2019-09-18 20:12 ` [PATCH] staging: exfat: rebase to sdFAT v2.2.0 Greg KH
2019-09-18 20:13 ` Greg KH
2019-09-18 20:22 ` Ju Hyung Park
2019-09-18 20:26 ` Greg KH
2019-09-18 20:31 ` Ju Hyung Park
2019-09-18 20:46 ` Valdis Klētnieks
2019-09-18 21:31 ` kbuild test robot
2019-09-18 21:31 ` kbuild test robot
2019-09-18 22:17 ` Ju Hyung Park
2019-10-24 9:39 ` [PATCH] staging: exfat: add exfat filesystem code to staging Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829094136.GA28643@infradead.org \
--to=hch@infradead.org \
--cc=alexander.levin@microsoft.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).