From: Ritesh Harjani <riteshh@linux.ibm.com>
To: linux-fsdevel@vger.kernel.org
Cc: riteshh@linux.ibm.com
Subject: [RFC 1/2] direct-io: Change is_async member of struct dio from int to bool
Date: Fri, 30 Aug 2019 14:47:50 +0530 [thread overview]
Message-ID: <20190830091751.10284-2-riteshh@linux.ibm.com> (raw)
In-Reply-To: <20190830091751.10284-1-riteshh@linux.ibm.com>
Change is_async member of struct dio from int to bool.
Found this during code review.
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
---
fs/direct-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/direct-io.c b/fs/direct-io.c
index ae196784f487..b139876653ef 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -128,7 +128,7 @@ struct dio {
/* BIO completion state */
spinlock_t bio_lock; /* protects BIO fields below */
int page_errors; /* errno from get_user_pages() */
- int is_async; /* is IO async ? */
+ bool is_async; /* is IO async ? */
bool defer_completion; /* defer AIO completion to workqueue? */
bool should_dirty; /* if pages should be dirtied */
int io_error; /* IO error in completion path */
--
2.21.0
next prev parent reply other threads:[~2019-08-30 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 9:17 [PATCH 0/2] Trivial changes found during code-review Ritesh Harjani
2019-08-30 9:17 ` Ritesh Harjani [this message]
2019-08-30 9:17 ` [RFC 2/2] Doc: vfs: Update few inode specific super_operations methods Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830091751.10284-2-riteshh@linux.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).