From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB6E5C41514 for ; Tue, 3 Sep 2019 13:45:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D5DC2343A for ; Tue, 3 Sep 2019 13:45:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729090AbfICNo7 (ORCPT ); Tue, 3 Sep 2019 09:44:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:47960 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728490AbfICNo7 (ORCPT ); Tue, 3 Sep 2019 09:44:59 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 33DAFAE9A; Tue, 3 Sep 2019 13:44:58 +0000 (UTC) Date: Tue, 3 Sep 2019 08:44:55 -0500 From: Goldwyn Rodrigues To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, darrick.wong@oracle.com, david@fromorbit.com, riteshh@linux.ibm.com Subject: Re: [PATCH v3 0/15] Btrfs iomap Message-ID: <20190903134455.i323xy2wbmh4icsp@fiona> References: <20190901200836.14959-1-rgoldwyn@suse.de> <20190902164331.GE6263@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190902164331.GE6263@lst.de> User-Agent: NeoMutt/20180716 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 18:43 02/09, Christoph Hellwig wrote: > On Sun, Sep 01, 2019 at 03:08:21PM -0500, Goldwyn Rodrigues wrote: > > This is an effort to use iomap for btrfs. This would keep most > > responsibility of page handling during writes in iomap code, hence > > code reduction. For CoW support, changes are needed in iomap code > > to make sure we perform a copy before the write. > > This is in line with the discussion we had during adding dax support in > > btrfs. > > This looks pretty good modulo a few comments. > > Can you please convert the XFS code to use your two iomaps for COW > approach as well to validate it? > > Also the iomap_file_dirty helper would really benefit from using the > two iomaps, any chance you could look into improving it to use your > new infrastructure? Yes. However, I haven't looked at much of XFS code, but from the initial looks of it, it is simple to read. -- Goldwyn