From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D433EC3A5A2 for ; Tue, 3 Sep 2019 14:08:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B59A423431 for ; Tue, 3 Sep 2019 14:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729079AbfICOIC (ORCPT ); Tue, 3 Sep 2019 10:08:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41158 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727107AbfICOIC (ORCPT ); Tue, 3 Sep 2019 10:08:02 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 26B66C05AA52; Tue, 3 Sep 2019 14:08:02 +0000 (UTC) Received: from horse.redhat.com (unknown [10.18.25.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F2EB60C18; Tue, 3 Sep 2019 14:07:52 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 0D019220292; Tue, 3 Sep 2019 10:07:52 -0400 (EDT) Date: Tue, 3 Sep 2019 10:07:52 -0400 From: Vivek Goyal To: "Michael S. Tsirkin" Cc: Miklos Szeredi , Jason Wang , virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, virtio-fs@redhat.com, Stefan Hajnoczi , "Dr. David Alan Gilbert" Subject: Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines Message-ID: <20190903140752.GA10983@redhat.com> References: <20190821173742.24574-1-vgoyal@redhat.com> <20190903041507-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190903041507-mutt-send-email-mst@kernel.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 03 Sep 2019 14:08:02 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Sep 03, 2019 at 04:31:38AM -0400, Michael S. Tsirkin wrote: [..] > + /* TODO lock */ > give me pause. > > Cleanup generally seems broken to me - what pauses the FS I am looking into device removal aspect of it now. Thinking of adding a reference count to virtiofs device and possibly also a bit flag to indicate if device is still alive. That way, we should be able to cleanup device more gracefully. > > What about the rest of TODOs in that file? I will also take a closer look at TODOs now. Better device cleanup path might get rid of some of them. Some of them might not be valid anymore. > > use of usleep is hacky - can't we do better e.g. with a > completion? Agreed. Thanks Vivek