From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Jeff Layton <jlayton@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Gao Xiang <hsiangkao@aol.com>,
linux-fsdevel@vger.kernel.org, aneesh.kumar@linux.ibm.com,
wugyuan@cn.ibm.com
Subject: Re: [RFC] - vfs: Null pointer dereference issue with symlink create and read of symlink
Date: Fri, 6 Sep 2019 10:47:16 +0530 [thread overview]
Message-ID: <20190906051717.A87CDA4054@b06wcsmtp001.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <9b3433ebec78bb99690fd4805b329266edf21686.camel@kernel.org>
On 9/4/19 8:09 PM, Jeff Layton wrote:
>>> It seems much similar to
>>> https://lore.kernel.org/r/20190419084810.63732-1-houtao1@huawei.com/
>>
>> Thanks, yes two same symptoms with different use cases.
>> But except the fact that here, we see the issue with GPFS quite
>> frequently. So let's hope that we could have some solution to this
>> problem in upstream.
>>
>
> Agreed. Looks a lot like the same issue.
>
>> From the thread:-
>> >> We could simply use d_really_is_negative() there, avoiding all that
>> >> mess. If and when we get around to whiteouts-in-dcache (i.e. if
>> >> unionfs series gets resurrected), we can revisit that
>>
>> I didn't get this part. Does it mean, d_really_is_negative can only be
>> used, once whiteouts-in-dcache series is resurrected?
>> If yes, meanwhile could we have any other solution in place?
>>
>
> I think Al was saying that you could change this to use
> d_really_is_negative now but the whiteouts-in-dcache series would have
> to deal with that. That series seems to be stalled for the time being,
> so I wouldn't let it stop you from changing this.
>
> It wouldn't hurt to put in some comments with this change too, to make
> sure everyone understands why that's being used there.
Thanks Jeff. I did look at the thread again and yes you are right.
I have created the patch and added some comments as per your suggestion.
Once it is tested again internally (although it does looks like it
should work fine), I will post the patch.
Appreciate your help!!
-ritesh
prev parent reply other threads:[~2019-09-06 5:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 11:58 [RFC] - vfs: Null pointer dereference issue with symlink create and read of symlink Ritesh Harjani
2019-09-03 12:59 ` Gao Xiang
2019-09-03 13:41 ` Ritesh Harjani
2019-09-03 13:58 ` Gao Xiang
2019-09-04 14:39 ` Jeff Layton
2019-09-06 5:17 ` Ritesh Harjani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906051717.A87CDA4054@b06wcsmtp001.portsmouth.uk.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=hsiangkao@aol.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wugyuan@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).