From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Colin King <colin.king@canonical.com>
Cc: Gabriel Krisman Bertazi <krisman@collabora.com>,
linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] unicode: make array 'token' static const, makes object smaller
Date: Fri, 6 Sep 2019 11:31:47 -0400 [thread overview]
Message-ID: <20190906153147.GA2819@mit.edu> (raw)
In-Reply-To: <20190906135807.23152-1-colin.king@canonical.com>
On Fri, Sep 06, 2019 at 02:58:07PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array 'token' on the stack but instead make it
> static const. Makes the object code smaller by 234 bytes.
>
> Before:
> text data bss dec hex filename
> 5371 272 0 5643 160b fs/unicode/utf8-core.o
>
> After:
> text data bss dec hex filename
> 5041 368 0 5409 1521 fs/unicode/utf8-core.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Nice, thanks!
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
- Ted
next prev parent reply other threads:[~2019-09-06 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 13:58 [PATCH] unicode: make array 'token' static const, makes object smaller Colin King
2019-09-06 15:31 ` Theodore Y. Ts'o [this message]
2019-09-09 14:21 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906153147.GA2819@mit.edu \
--to=tytso@mit.edu \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krisman@collabora.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).