From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10DD0C49ED7 for ; Mon, 16 Sep 2019 12:53:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D174D2171F for ; Mon, 16 Sep 2019 12:53:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mbobrowski-org.20150623.gappssmtp.com header.i=@mbobrowski-org.20150623.gappssmtp.com header.b="W4usgsb7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732802AbfIPMxU (ORCPT ); Mon, 16 Sep 2019 08:53:20 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:40707 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732793AbfIPMxU (ORCPT ); Mon, 16 Sep 2019 08:53:20 -0400 Received: by mail-pg1-f196.google.com with SMTP id w10so19800880pgj.7 for ; Mon, 16 Sep 2019 05:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zJYJFM/Q/O8KCi3hF19Zx6Yw3YMNVDSIL1QMzh6ZZ5I=; b=W4usgsb7XXHacpAoquAX4WfXTwndcwoKV76Azx7+s8A4uRc6neRN9uihS1ZHPL8cpd eMPR74J5RU+4f80639uGv5pi+uuaItd2fI/d6vdCav6+6wAryNDEgZmrv30FhUpuHuJy nG91JlCx9HRFflwBNTQ32y6RGPR8MTbEvT5tEjSo56nXrH0qML3yaQIJwldAMyD74eqL oVvRhv41dvGs00ePCQBbgJmbfcxV4ztSkNhqPGaF71dGDkG6aAKhn8tqMQZOiAgRV66p cTbD24j9nayB8bGisgXSMPLvRZ9gr1dSxTbycxfEBMRS1NqMggIoERh7NXVVPL9zr7mN BzOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zJYJFM/Q/O8KCi3hF19Zx6Yw3YMNVDSIL1QMzh6ZZ5I=; b=F2xq11H+pEiwQjZCus6ndpBhMmV6Y+s7RIlXv/UdelOqz+xhF7p3GgRbF7Bn6viDKE JQUyKdN0fEPqlbp4VFplbwKQK+w1b49cGLBFMTxFQEkPVKRMCo1oI0A505ZXKj0urGyN 4dg2WbgTnkO97IJAQB7Qw8TYIU5q7u3c6ScDq2/bu6NpBuSdMscv4bqW4KUMLIDpzHwj QuKhJ1Dma6VZNnbQ8pc1bawIlVOISGOQ12grIfJAJP26F4L4LmUSvUB/OeoIDi22O0SO fB9FR4xNT1RW+/S+TnFnOgWlRoqENpx/fc4rIRyI63p/NVM+SZynxosDgZAKHPSAdtr4 H5XA== X-Gm-Message-State: APjAAAXpy57vbhKe6vgRosEZopTfdnc9jtans5mHhYTYO41b28ovTrRd QfX5YZ9Q3+InDyAZK4Ef6r3dknsnZHbx X-Google-Smtp-Source: APXvYqzjACRpVyZJfkp5gG5GDDBnZZ+u5/+W2hz3bIAv6x7Fe0D9Z+q0ymw8TsqwKLOa3ofC+CeZXA== X-Received: by 2002:a63:4c5a:: with SMTP id m26mr55117967pgl.270.1568638399033; Mon, 16 Sep 2019 05:53:19 -0700 (PDT) Received: from bobrowski ([110.232.114.101]) by smtp.gmail.com with ESMTPSA id b3sm57723721pfp.65.2019.09.16.05.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2019 05:53:18 -0700 (PDT) Date: Mon, 16 Sep 2019 22:53:12 +1000 From: Matthew Bobrowski To: Christoph Hellwig Cc: tytso@mit.edu, jack@suse.cz, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH v3 6/6] ext4: cleanup legacy buffer_head direct IO code Message-ID: <20190916125312.GC4024@bobrowski> References: <1d83ac7f8088837064b90cfb3182a37b46356239.1568282664.git.mbobrowski@mbobrowski.org> <20190916120632.GC4005@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190916120632.GC4005@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Sep 16, 2019 at 05:06:32AM -0700, Christoph Hellwig wrote: > On Thu, Sep 12, 2019 at 09:05:03PM +1000, Matthew Bobrowski wrote: > > Remove buffer_head direct IO code that is now redundant as a result of > > porting across the read/write paths to use iomap infrastructure. > > I still think moving the removal of the not required code into the > actual patches that make the code obsolete is a better idea. That > makes it very clear what is added to remove what kind and amount of > old code. Yeah, you're right, I completely agree with that now that you mention it. I will do this for the next version of this patch series. ----