From: Carlos Maiolino <cmaiolino@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, hch@lst.de, adilger@dilger.ca,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 9/9] xfs: Get rid of ->bmap
Date: Wed, 18 Sep 2019 10:13:04 +0200 [thread overview]
Message-ID: <20190918081303.zwnxr7pvtotr7cnt@pegasus.maiolino.io> (raw)
In-Reply-To: <20190916175049.GD2229799@magnolia>
On Mon, Sep 16, 2019 at 10:50:49AM -0700, Darrick J. Wong wrote:
> On Wed, Sep 11, 2019 at 03:43:15PM +0200, Carlos Maiolino wrote:
> > We don't need ->bmap anymore, only usage for it was FIBMAP, which is now
> > gone.
> >
> > Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> > ---
> >
> > Changelog:
> > V5:
> > - Properly rebase against 5.3
> > - iomap_{bmap(),bmap_actor()} are now used also by GFS2, so
> > don't remove them anymore
> > V2:
> > - Kill iomap_bmap() and iomap_bmap_actor()
> >
> > fs/xfs/xfs_aops.c | 24 ------------------------
> > fs/xfs/xfs_trace.h | 1 -
> > 2 files changed, 25 deletions(-)
> >
> > diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> > index 4e4a4d7df5ac..a2884537d2c2 100644
> > --- a/fs/xfs/xfs_aops.c
> > +++ b/fs/xfs/xfs_aops.c
> > @@ -1138,29 +1138,6 @@ xfs_vm_releasepage(
> > return iomap_releasepage(page, gfp_mask);
> > }
> >
> > -STATIC sector_t
> > -xfs_vm_bmap(
> > - struct address_space *mapping,
> > - sector_t block)
> > -{
> > - struct xfs_inode *ip = XFS_I(mapping->host);
> > -
> > - trace_xfs_vm_bmap(ip);
> > -
> > - /*
> > - * The swap code (ab-)uses ->bmap to get a block mapping and then
> > - * bypasses the file system for actual I/O. We really can't allow
> > - * that on reflinks inodes, so we have to skip out here. And yes,
> > - * 0 is the magic code for a bmap error.
> > - *
> > - * Since we don't pass back blockdev info, we can't return bmap
> > - * information for rt files either.
> > - */
> > - if (xfs_is_cow_inode(ip) || XFS_IS_REALTIME_INODE(ip))
>
> Uhhhh where does this check happen now?
All checks are now made in the caller, bmap_fiemap() based on the filesystem's
returned flags in the fiemap structure. So, it will decide to pass the result
back, or just return -EINVAL.
Well, there is no way for iomap (or bmap_fiemap now) detect the block is in a
realtime device, since we have no flags for that.
Following Christoph's line of thought here, maybe we can add a new IOMAP_F_* so
the filesystem can notify iomap the extent is in a different device? I don't
know, just a thought.
This would still keep the consistency of leaving bmap_fiemap() with the decision
of passing or not.
Cheers.
>
> --D
>
> > - return 0;
> > - return iomap_bmap(mapping, block, &xfs_iomap_ops);
> > -}
> > -
> > STATIC int
> > xfs_vm_readpage(
> > struct file *unused,
> > @@ -1199,7 +1176,6 @@ const struct address_space_operations xfs_address_space_operations = {
> > .set_page_dirty = iomap_set_page_dirty,
> > .releasepage = xfs_vm_releasepage,
> > .invalidatepage = xfs_vm_invalidatepage,
> > - .bmap = xfs_vm_bmap,
> > .direct_IO = noop_direct_IO,
> > .migratepage = iomap_migrate_page,
> > .is_partially_uptodate = iomap_is_partially_uptodate,
> > diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
> > index eaae275ed430..c226b562f5da 100644
> > --- a/fs/xfs/xfs_trace.h
> > +++ b/fs/xfs/xfs_trace.h
> > @@ -626,7 +626,6 @@ DEFINE_INODE_EVENT(xfs_readdir);
> > #ifdef CONFIG_XFS_POSIX_ACL
> > DEFINE_INODE_EVENT(xfs_get_acl);
> > #endif
> > -DEFINE_INODE_EVENT(xfs_vm_bmap);
> > DEFINE_INODE_EVENT(xfs_file_ioctl);
> > DEFINE_INODE_EVENT(xfs_file_compat_ioctl);
> > DEFINE_INODE_EVENT(xfs_ioctl_setattr);
> > --
> > 2.20.1
> >
--
Carlos
next prev parent reply other threads:[~2019-09-18 8:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 13:43 [PATCH 0/9 V6] New ->fiemap infrastructure and ->bmap removal Carlos Maiolino
2019-09-11 13:43 ` [PATCH 1/9] fs: Enable bmap() function to properly return errors Carlos Maiolino
2019-09-11 13:43 ` [PATCH 2/9] cachefiles: drop direct usage of ->bmap method Carlos Maiolino
2019-09-11 13:43 ` [PATCH 3/9] ecryptfs: drop direct calls to ->bmap Carlos Maiolino
2019-09-11 13:43 ` [PATCH 4/9] fibmap: Use bmap instead of ->bmap method in ioctl_fibmap Carlos Maiolino
2019-09-11 13:43 ` [PATCH 5/9] fs: Move start and length fiemap fields into fiemap_extent_info Carlos Maiolino
2019-09-16 17:42 ` Darrick J. Wong
2019-09-11 13:43 ` [PATCH 6/9] iomap: Remove length and start fields from iomap_fiemap Carlos Maiolino
2019-09-11 13:43 ` [PATCH 7/9] fiemap: Use a callback to fill fiemap extents Carlos Maiolino
2019-09-11 13:43 ` [PATCH 8/9] Use FIEMAP for FIBMAP calls Carlos Maiolino
2019-09-16 17:44 ` Darrick J. Wong
2019-09-11 13:43 ` [PATCH 9/9] xfs: Get rid of ->bmap Carlos Maiolino
2019-09-16 17:50 ` Darrick J. Wong
2019-09-18 8:13 ` Carlos Maiolino [this message]
2019-09-18 13:24 ` Christoph Hellwig
2019-09-18 16:12 ` Darrick J. Wong
2019-09-23 8:52 ` Carlos Maiolino
2019-09-27 8:59 ` [PATCH 0/9 V6] New ->fiemap infrastructure and ->bmap removal Carlos Maiolino
2019-09-30 8:10 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2019-08-08 8:27 [PATCH 0/9 V5] " Carlos Maiolino
2019-08-08 8:27 ` [PATCH 9/9] xfs: Get rid of ->bmap Carlos Maiolino
2019-07-31 14:12 [PATCH 0/9 V4] New ->fiemap infrastructure and ->bmap removal Carlos Maiolino
2019-07-31 14:12 ` [PATCH 9/9] xfs: Get rid of ->bmap Carlos Maiolino
2019-07-31 23:30 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918081303.zwnxr7pvtotr7cnt@pegasus.maiolino.io \
--to=cmaiolino@redhat.com \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).