From: Matthew Wilcox <willy@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/15] fs: Introduce i_blocks_per_page
Date: Fri, 4 Oct 2019 12:28:12 -0700 [thread overview]
Message-ID: <20191004192812.GK32665@bombadil.infradead.org> (raw)
In-Reply-To: <20190925083650.GE804@dread.disaster.area>
On Wed, Sep 25, 2019 at 06:36:50PM +1000, Dave Chinner wrote:
> I'm actually working on abstrcting this code from both block size
> and page size via the helpers below. We ahve need to support block
> size > page size, and so that requires touching a bunch of all the
> same code as this patchset. I'm currently trying to combine your
> last patch set with my patchset so I can easily test allocating 64k
> page cache pages on a 64k block size filesystem on a 4k page size
> machine with XFS....
This all makes sense ...
> > - if (iop || i_blocksize(inode) == PAGE_SIZE)
> > + if (iop || i_blocks_per_page(inode, page) <= 1)
> > return iop;
>
> That also means checks like these become:
>
> if (iop || iomap_chunks_per_page(inode, page) <= 1)
>
> as a single file can now have multiple pages per block, a page per
> block and multiple blocks per page as the page size changes...
>
> I'd like to only have to make one pass over this code to abstract
> out page and block sizes, so I'm guessing we'll need to do some
> co-ordination here....
Yup. I'm happy if you want to send your patches out; I'll keep going
with the patches I have for the moment, and we'll figure out how to
merge the two series in a way that makes sense.
next prev parent reply other threads:[~2019-10-04 19:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 0:51 [RFC 00/15] Large pages in the page-cache Matthew Wilcox
2019-09-25 0:52 ` [PATCH 01/15] mm: Use vm_fault error code directly Matthew Wilcox
2019-09-26 13:55 ` Kirill A. Shutemov
2019-09-25 0:52 ` [PATCH 02/15] fs: Introduce i_blocks_per_page Matthew Wilcox
2019-09-25 8:36 ` Dave Chinner
2019-10-04 19:28 ` Matthew Wilcox [this message]
2019-10-08 3:53 ` Dave Chinner
2019-09-25 0:52 ` [PATCH 03/15] mm: Add file_offset_of_ helpers Matthew Wilcox
2019-09-26 14:02 ` Kirill A. Shutemov
2019-10-04 19:39 ` Matthew Wilcox
2019-09-25 0:52 ` [PATCH 04/15] iomap: Support large pages Matthew Wilcox
2019-09-25 0:52 ` [PATCH 05/15] xfs: " Matthew Wilcox
2019-09-25 0:52 ` [PATCH 06/15] xfs: Pass a page to xfs_finish_page_writeback Matthew Wilcox
2019-09-25 0:52 ` [PATCH 07/15] mm: Make prep_transhuge_page tail-callable Matthew Wilcox
2019-09-26 14:13 ` Kirill A. Shutemov
2019-09-25 0:52 ` [PATCH 08/15] mm: Add __page_cache_alloc_order Matthew Wilcox
2019-09-26 14:15 ` Kirill A. Shutemov
2019-09-25 0:52 ` [PATCH 09/15] mm: Allow large pages to be added to the page cache Matthew Wilcox
2019-09-26 14:22 ` Kirill A. Shutemov
2019-09-25 0:52 ` [PATCH 10/15] mm: Allow find_get_page to be used for large pages Matthew Wilcox
2019-10-01 10:32 ` Kirill A. Shutemov
2019-09-25 0:52 ` [PATCH 11/15] mm: Remove hpage_nr_pages Matthew Wilcox
2019-10-01 10:35 ` Kirill A. Shutemov
2019-09-25 0:52 ` [PATCH 12/15] mm: Support removing arbitrary sized pages from mapping Matthew Wilcox
2019-10-01 10:39 ` Kirill A. Shutemov
2019-09-25 0:52 ` [PATCH 13/15] mm: Add a huge page fault handler for files Matthew Wilcox
2019-10-01 10:42 ` Kirill A. Shutemov
2019-09-25 0:52 ` [PATCH 14/15] mm: Align THP mappings for non-DAX Matthew Wilcox
2019-10-01 10:45 ` Kirill A. Shutemov
2019-10-01 11:21 ` William Kucharski
2019-10-01 11:32 ` Kirill A. Shutemov
2019-10-01 12:18 ` William Kucharski
2019-10-01 14:20 ` Kirill A. Shutemov
2019-10-01 16:08 ` William Kucharski
2019-10-02 0:15 ` Kirill A. Shutemov
2019-09-25 0:52 ` [PATCH 15/15] xfs: Use filemap_huge_fault Matthew Wilcox
[not found] ` <20191002130753.7680-1-hdanton@sina.com>
2019-10-04 19:33 ` [PATCH 03/15] mm: Add file_offset_of_ helpers Matthew Wilcox
[not found] ` <20191002133211.15696-1-hdanton@sina.com>
2019-10-04 19:34 ` [PATCH 04/15] iomap: Support large pages Matthew Wilcox
[not found] ` <20191003040846.17604-1-hdanton@sina.com>
2019-10-04 19:35 ` [PATCH 06/15] xfs: Pass a page to xfs_finish_page_writeback Matthew Wilcox
[not found] ` <20191003050859.18140-1-hdanton@sina.com>
2019-10-04 19:36 ` [PATCH 11/15] mm: Remove hpage_nr_pages Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004192812.GK32665@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).