From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B49A2C10F14 for ; Tue, 8 Oct 2019 15:38:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80031217D7 for ; Tue, 8 Oct 2019 15:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570549117; bh=gjdt14TlOZyesMNTH7/5zSE94bMrmk0OHHv7OXJGXaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=K9FJ4QQ58NDG1sG2bv8zIY/nLRXvC5BaPl+AnEPk2530BkBSbW8BIJqDNrSV2ehKY s9r1hGwASA46XpAOzP9ryc6vQ3mJrtn8ebtLLFEMw9LE6ZUpqOFUTnZ5ZKhPzmhw6Q x7LQhvIhYfXbWn7Z6I+FPsy0IN4JvVHBl/+Ojo1Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726186AbfJHPih (ORCPT ); Tue, 8 Oct 2019 11:38:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:45858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbfJHPig (ORCPT ); Tue, 8 Oct 2019 11:38:36 -0400 Received: from localhost (unknown [89.205.136.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 02E902070B; Tue, 8 Oct 2019 15:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570549114; bh=gjdt14TlOZyesMNTH7/5zSE94bMrmk0OHHv7OXJGXaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g6Hw1hA8MaxUCugwMm+KqWjnL4ueUeMaByU1o/g241xDYq/YvMvFCndcGgL6KBg/C CHK3kljSd/j9kMjl7/uRDDwzU2ShSfUUaXtN72uf53LWFMLpVY0qDHQRe7XZu0H+F7 SbqoQhju7xWNE5hakgvm6d5VXqDy9Jl7ziRTVI9k= Date: Tue, 8 Oct 2019 17:38:31 +0200 From: Greg KH To: Al Viro Cc: Linus Torvalds , Guenter Roeck , Linux Kernel Mailing List , linux-fsdevel Subject: Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user() Message-ID: <20191008153831.GA2881123@kroah.com> References: <20191007012437.GK26530@ZenIV.linux.org.uk> <20191007025046.GL26530@ZenIV.linux.org.uk> <20191008032912.GQ26530@ZenIV.linux.org.uk> <20191008045712.GR26530@ZenIV.linux.org.uk> <20191008131416.GA2860109@kroah.com> <20191008152900.GT26530@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191008152900.GT26530@ZenIV.linux.org.uk> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Oct 08, 2019 at 04:29:00PM +0100, Al Viro wrote: > On Tue, Oct 08, 2019 at 03:14:16PM +0200, Greg KH wrote: > > On Tue, Oct 08, 2019 at 05:57:12AM +0100, Al Viro wrote: > > > > > > OK... BTW, do you agree that the use of access_ok() in > > > drivers/tty/n_hdlc.c:n_hdlc_tty_read() is wrong? It's used as an early > > > cutoff, so we don't bother waiting if user has passed an obviously bogus > > > address. copy_to_user() is used for actual copying there... > > > > Yes, it's wrong, and not needed. I'll go rip it out unless you want to? > > I'll throw it into misc queue for now; it has no prereqs and nothing is going > to depend upon it. Great, thanks. > While looking for more of the same pattern: usb_device_read(). Frankly, > usb_device_dump() calling conventions look ugly - it smells like it > would be much happier as seq_file. Iterator would take some massage, > but that seems to be doable. Anyway, that's a separate story... That's just a debugfs file, and yes, it should be moved to seq_file. I think I tried it a long time ago, but given it's just a debugging thing, I gave up as it wasn't worth it. But yes, the access_ok() there also seems odd, and should be dropped. thanks, greg k-h