Linux-Fsdevel Archive on
 help / color / Atom feed
From: Ben Dooks <>
Cc: Ben Dooks <>,
	Alexander Viro <>,,
Subject: [PATCH] fs: include internal.h for missing declarations
Date: Fri, 11 Oct 2019 18:00:39 +0100
Message-ID: <> (raw)

The declarations of __block_write_begin_int and guard_bio_eod
are needed from internal.h so include it to fix the following
sparse warnings:

fs/buffer.c:1930:5: warning: symbol '__block_write_begin_int' was not declared. Should it be static?
fs/buffer.c:2994:6: warning: symbol 'guard_bio_eod' was not declared. Should it be static?

Signed-off-by: Ben Dooks <>
Cc: Alexander Viro <>
 fs/buffer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/buffer.c b/fs/buffer.c
index 86a38b979323..792f22a88e67 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -48,6 +48,8 @@
 #include <linux/sched/mm.h>
 #include <trace/events/block.h>
+#include "internal.h"
 static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
 static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
 			 enum rw_hint hint, struct writeback_control *wbc);

             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 17:00 Ben Dooks [this message]
2019-10-15  8:05 ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Fsdevel Archive on

Archives are clonable:
	git clone --mirror linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ \
	public-inbox-index linux-fsdevel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone