From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com,
msys.mizuma@gmail.com
Subject: Re: [PATCH] virtio_fs: Change module name to virtiofs.ko
Date: Sat, 12 Oct 2019 11:23:47 +0100 [thread overview]
Message-ID: <20191012102347.GB17940@stefanha-x1.localdomain> (raw)
In-Reply-To: <20191011181826.GA13861@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1827 bytes --]
On Fri, Oct 11, 2019 at 02:18:26PM -0400, Vivek Goyal wrote:
> We have been calling it virtio_fs and even file name is virtio_fs.c. Module
> name is virtio_fs.ko but when registering file system user is supposed to
> specify filesystem type as "virtiofs".
>
> Masayoshi Mizuma reported that he specified filesytem type as "virtio_fs" and
> got this warning on console.
>
> ------------[ cut here ]------------
> request_module fs-virtio_fs succeeded, but still no fs?
> WARNING: CPU: 1 PID: 1234 at fs/filesystems.c:274 get_fs_type+0x12c/0x138
> Modules linked in: ... virtio_fs fuse virtio_net net_failover ...
> CPU: 1 PID: 1234 Comm: mount Not tainted 5.4.0-rc1 #1
>
> So looks like kernel could find the module virtio_fs.ko but could not find
> filesystem type after that.
>
> It probably is better to rename module name to virtiofs.ko so that above
> warning goes away in case user ends up specifying wrong fs name.
>
> Reported-by: Masayoshi Mizuma <msys.mizuma@gmail.com>
> Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> ---
> fs/fuse/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: rhvgoyal-linux/fs/fuse/Makefile
> ===================================================================
> --- rhvgoyal-linux.orig/fs/fuse/Makefile 2019-10-11 13:53:43.905757435 -0400
> +++ rhvgoyal-linux/fs/fuse/Makefile 2019-10-11 13:54:24.147757435 -0400
> @@ -5,6 +5,7 @@
>
> obj-$(CONFIG_FUSE_FS) += fuse.o
> obj-$(CONFIG_CUSE) += cuse.o
> -obj-$(CONFIG_VIRTIO_FS) += virtio_fs.o
> +obj-$(CONFIG_VIRTIO_FS) += virtiofs.o
>
> fuse-objs := dev.o dir.o file.o inode.o control.o xattr.o acl.o readdir.o
> +virtiofs-y += virtio_fs.o
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-12 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 18:18 [PATCH] virtio_fs: Change module name to virtiofs.ko Vivek Goyal
2019-10-12 1:50 ` Masayoshi Mizuma
2019-10-12 10:23 ` Stefan Hajnoczi [this message]
2019-10-14 8:25 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012102347.GB17940@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=msys.mizuma@gmail.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).