From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Naohiro Aota <naohiro.aota@wdc.com>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2] mm, swap: disallow swapon() on zoned block devices
Date: Tue, 15 Oct 2019 13:43:57 -0700 [thread overview]
Message-ID: <20191015134357.042f39a02ae438d961aa2aca@linux-foundation.org> (raw)
In-Reply-To: <20191015090641.GB7199@infradead.org>
On Tue, 15 Oct 2019 02:06:41 -0700 Christoph Hellwig <hch@infradead.org> wrote:
> > + /*
> > + * Zoned block device contains zones that have
> > + * sequential write only restriction. For the restriction,
> > + * zoned block devices are not suitable for a swap device.
> > + * Disallow them here.
> > + */
> > + if (blk_queue_is_zoned(p->bdev->bd_queue))
>
> Please use up all 80 chars per line Otherwise this looks fine:
I redid the text a bit as well.
--- a/mm/swapfile.c~mm-swap-disallow-swapon-on-zoned-block-devices-fix
+++ a/mm/swapfile.c
@@ -2888,10 +2888,9 @@ static int claim_swapfile(struct swap_in
if (error < 0)
return error;
/*
- * Zoned block device contains zones that have
- * sequential write only restriction. For the restriction,
- * zoned block devices are not suitable for a swap device.
- * Disallow them here.
+ * Zoned block devices contain zones that have a sequential
+ * write only restriction. Hence zoned block devices are not
+ * suitable for swapping. Disallow them here.
*/
if (blk_queue_is_zoned(p->bdev->bd_queue))
return -EINVAL;
_
next prev parent reply other threads:[~2019-10-15 20:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 4:38 [PATCH] mm, swap: disallow swapon() on zoned block devices Naohiro Aota
2019-10-15 7:57 ` Christoph Hellwig
2019-10-15 8:58 ` [PATCH v2] " Naohiro Aota
2019-10-15 9:06 ` Christoph Hellwig
2019-10-15 20:43 ` Andrew Morton [this message]
2019-10-15 11:35 ` Project idea: Swap to " Matthew Wilcox
2019-10-15 13:27 ` Theodore Y. Ts'o
2019-10-15 13:48 ` Hannes Reinecke
2019-10-15 14:50 ` Christopher Lameter
2019-10-15 15:09 ` Matthew Wilcox
2019-10-15 15:22 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015134357.042f39a02ae438d961aa2aca@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).