From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Gruenbacher <agruenba@redhat.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Bob Peterson <rpeterso@redhat.com>
Subject: Re: [PATCH v3] splice: only read in as much information as there is pipe buffer space
Date: Wed, 16 Oct 2019 11:52:54 -0700 [thread overview]
Message-ID: <20191016185254.GH13098@magnolia> (raw)
In-Reply-To: <20191016184549.GB720@sol.localdomain>
On Wed, Oct 16, 2019 at 11:45:49AM -0700, Eric Biggers wrote:
> On Mon, Oct 14, 2019 at 03:09:40PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Andreas Grünbacher reports that on the two filesystems that support
> > iomap directio, it's possible for splice() to return -EAGAIN (instead of
> > a short splice) if the pipe being written to has less space available in
> > its pipe buffers than the length supplied by the calling process.
> >
> > Months ago we fixed splice_direct_to_actor to clamp the length of the
> > read request to the size of the splice pipe. Do the same to do_splice.
> >
> > Fixes: 17614445576b6 ("splice: don't read more than available pipe space")
> > Reported-by: syzbot+3c01db6025f26530cf8d@syzkaller.appspotmail.com
>
> I already invalidated this syzbot report when the previous version of this patch
> was dropped, as that was what the report appeared to be for. So you don't need
> this Reported-by line. It's not a big deal, but including it could mislead
> people into thinking that syzbot found a problem with the commit in the Fixes:
> line, rather than a prior version of this patch.
Ok, will drop for v4. Thanks for taking care of the report.
--D
> - Eric
prev parent reply other threads:[~2019-10-16 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 22:09 [PATCH v3] splice: only read in as much information as there is pipe buffer space Darrick J. Wong
2019-10-15 11:31 ` Andreas Grünbacher
2019-10-16 3:12 ` Dave Chinner
2019-10-16 18:54 ` Darrick J. Wong
2019-10-16 18:45 ` Eric Biggers
2019-10-16 18:52 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016185254.GH13098@magnolia \
--to=darrick.wong@oracle.com \
--cc=agruenba@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=rpeterso@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).