From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0456ACA9EB7 for ; Tue, 22 Oct 2019 01:55:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CECEA2084C for ; Tue, 22 Oct 2019 01:55:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mbobrowski-org.20150623.gappssmtp.com header.i=@mbobrowski-org.20150623.gappssmtp.com header.b="uBEd/EfM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730304AbfJVBzm (ORCPT ); Mon, 21 Oct 2019 21:55:42 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43911 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729270AbfJVBzm (ORCPT ); Mon, 21 Oct 2019 21:55:42 -0400 Received: by mail-pg1-f196.google.com with SMTP id l24so4009918pgh.10 for ; Mon, 21 Oct 2019 18:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rXswSMoB6Vxiulruunf+j1WjpnPVrwSDRmEMg90Vl74=; b=uBEd/EfMzezMsk6Y8W/1NSOiP78AqJj9abh7/QXDIjrhPVfdPpDGjO2RyzExzbL764 nzfRaSRm+ehOA5Mi9MS/F2JmjVdDW/nlHgGjnWvxEmrOCQSZSR6TQ3B3jS8a7guPFEgS uyGNtAPzol1FP36zyzwWndKI8Kfl3dSZDY1umsbxy4FgIk53pZRcrqAS7VZuzd6D92t6 9FMHUQoW5d+j64XcSqGLoBESRiGxXpriW4zVZgLMGIXveX9EKy8snTzNvrTxWqUvjfKB WMkyJiC4GFYGS/TmBTrs/c3kCozCV678bRcgirozfRpCEkD4NSPCOCogd4qYIqWIbADO C75Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rXswSMoB6Vxiulruunf+j1WjpnPVrwSDRmEMg90Vl74=; b=J1MN+xj4S2vSGC32ASd/C9ehB44y4zBSQ/WNnwnJLlDBYCeG37m/Auwc6AsEXWPlaD XVyuOSq5HH8MTcRC2zTRiz41YfSrzAy5I4dtl/ilzT0ED7V5uTQ4WJL2vz0aAqOOcdae Aa2tIi7wnfNh00K5HV7aDtt26MeZwxHDKi5efVSYh3LleJ9GO7Bvl7lAXuujTAzbbUyh cgPXskcD1l4i5Ttx2HSKzErqOHkTPnpY2sFlsKZaF9m2Edkeh091YMu+jYb+jpnN5gSM 55vplDIOYsvuR+WdkOu69F+OBanaQEprxi+3XZDn/4dhUReKC8WaZuC+gEX5vO/AuOxM UI4w== X-Gm-Message-State: APjAAAWT6Fbp0dngT+3V7nphMzRCMGyzHG1dhyaJ9w80bMkOuinDe1X6 2ajrUSfto/8B0tCrwWDnOr2n X-Google-Smtp-Source: APXvYqwocGKZ1xwGxi8lbWo39SllcPl9fBSfPUwLygHvmL0pUXydyrcCdDSz0hsF9/AF7pE3jybx6Q== X-Received: by 2002:a65:6701:: with SMTP id u1mr983201pgf.368.1571709341636; Mon, 21 Oct 2019 18:55:41 -0700 (PDT) Received: from athena.bobrowski.net (n1-41-199-60.bla2.nsw.optusnet.com.au. [1.41.199.60]) by smtp.gmail.com with ESMTPSA id v2sm192596pjr.14.2019.10.21.18.55.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 18:55:40 -0700 (PDT) Date: Tue, 22 Oct 2019 12:55:35 +1100 From: Matthew Bobrowski To: Jan Kara Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH v5 04/12] ext4: introduce new callback for IOMAP_REPORT Message-ID: <20191022015535.GC5092@athena.bobrowski.net> References: <20191021133715.GD25184@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191021133715.GD25184@quack2.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Oct 21, 2019 at 03:37:15PM +0200, Jan Kara wrote: > On Mon 21-10-19 20:18:09, Matthew Bobrowski wrote: > One nit below. > > + ext4_es_find_extent_range(inode, &ext4_es_is_delayed, > > + map->m_lblk, end, &es); > > + > > + if (!es.es_len || es.es_lblk > end) > > + return false; > > + > > + if (es.es_lblk > map->m_lblk) { > > + map->m_len = es.es_lblk - map->m_lblk; > > + return false; > > + } > > + > > + if (es.es_lblk <= map->m_lblk) > > This condition must be always true AFAICT. That would make sense. I will remove this condition in v6. > > + offset = map->m_lblk - es.es_lblk; > > + > > + map->m_lblk = es.es_lblk + offset; > > + map->m_len = es.es_len - offset; > > + > > + return true; > > +} ----